From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 518398E67
 for <dev@dpdk.org>; Wed, 11 Nov 2015 18:31:05 +0100 (CET)
Received: by pacdm15 with SMTP id dm15so36401100pac.3
 for <dev@dpdk.org>; Wed, 11 Nov 2015 09:31:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber_org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=+QQxMVeIaLv/W0s5WCr3sEn0zW/gCR67F2VX1ITkDPw=;
 b=NE2dSMniWIeYw5qjrazwgcXfhTMV8N5nrNDC8pHwUMUbXXBSS8IULnleg40AC9ZjXG
 DhQAUMFOLsWdFqyxNdibgrvpRv5cidQCW59guQMLkCvPxwICuhaD8aQ0UgkRtg+L07P/
 ZMKzW8p1vHfOgvs3suzGAHLjtAb2K5TNHlxP7kjBjZsVISP22QXgdsUisuecWIsGcDfT
 /rYsX6hYkbIgXuHMmeByZOwi6GedLk8rtt+/qBJiFKTCUdoyMmOTrrminOCqGEzCY0/f
 bLN998NV7LL+2LkY8UighiSROQ4waQwaSUH0VwjZXQWlKjbriZJiTCzXeEb7WAtI7jOv
 LChg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=+QQxMVeIaLv/W0s5WCr3sEn0zW/gCR67F2VX1ITkDPw=;
 b=Gjk6cEuqnZI0wKQqSBm/ey+wS8b4NfHrjVrDUkXQawOV5RTzq1kQ+JOXZtX9LOH/aQ
 XjfRNpy6XeJgo/l0xUzwFq6DN3O0/Gf1W/OJ8hIWNKQevMDIwGbWfoMpxjXskI6LIiC1
 v1punkBPhZGnCeB8rt4P2UGPx9G+TZC9u3Bu4MDa2OIgAkn85ZMTXsyfRT8FsP0EU+5u
 IXBUWtmLU3feDDdX/P/z7bxQX+HNTDizJhHUJqt9uq224LHriT2gGlQFq3nJJwKxgI4O
 1aNA5qkQFaSpIabBhekDM9QStyTSeJ5ac20uxDw3BG096b3xk+UePk3oTCPUvxzdNKOc
 4/+Q==
X-Gm-Message-State: ALoCoQnHsYYlszPcXwVaqu8MeeEzaJxtn2NdN5bMREdv3zx0pblBvqMEVe6uTj2bJ6vrw4+TmWXj
X-Received: by 10.68.65.42 with SMTP id u10mr16131800pbs.8.1447263064391;
 Wed, 11 Nov 2015 09:31:04 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id ea1sm10367003pbb.76.2015.11.11.09.31.03
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 11 Nov 2015 09:31:04 -0800 (PST)
Date: Wed, 11 Nov 2015 09:31:14 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20151111093114.46bb40ee@xeon-e3>
In-Reply-To: <20151111082657.GZ2326@yliu-dev.sh.intel.com>
References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com>
 <1447224046-1169-4-git-send-email-jijiang.liu@intel.com>
 <20151111082657.GZ2326@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 3/8] virtio/lib:add vhost TX checksum
 support capabilities
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2015 17:31:05 -0000

On Wed, 11 Nov 2015 16:26:57 +0800
Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:

> On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote:
> > Add vhost TX offload(CSUM and TSO) support capabilities.
> 
> Claiming first that we support something, and then actually implementing
> in a later patch is wrong, as at this stage, we actually does not support
> that, hence, the functionality is broken.
> 
> 	--yliu

Actually in this case it is okay to claim that driver "might" use offload
cabability but never do it. But agree in general better to keep both together.