From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C78128D85 for ; Wed, 11 Nov 2015 13:49:51 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 11 Nov 2015 04:49:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,275,1444719600"; d="scan'208";a="598257827" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2015 04:49:50 -0800 Date: Wed, 11 Nov 2015 20:53:46 +0800 From: Yuanhan Liu To: "Liu, Jijiang" Message-ID: <20151111125346.GD2326@yliu-dev.sh.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-8-git-send-email-jijiang.liu@intel.com> <20151111083118.GA2326@yliu-dev.sh.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA719@SHSMSX101.ccr.corp.intel.com> <20151111084419.GC2326@yliu-dev.sh.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 12:49:52 -0000 On Wed, Nov 11, 2015 at 08:53:08AM +0000, Liu, Jijiang wrote: ... > > If so, you'd better quote them here, or even to your patch commit. > > In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02, > > (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksum. > > (2) If the VIRTIO_NET_F_GUEST_CSUM feature was negotiated, the VIRTIO_NET_HDR_F_NEEDS_- > CSUM bit in flags MAY be set: if so, the checksum on the packet is incomplete and csum_start > and csum_offset indicate how to calculate it (see Packet Transmission point 1). > > (3) If the VIRTIO_NET_F_GUEST_TSO4, TSO6 or UFO options were negotiated, then gso_type > MAY be something other than VIRTIO_NET_HDR_GSO_NONE, and gso_size field indicates > the desired MSS (see Packet Transmission point 2). Thanks. Yes, sound like we need set them. --yliu > > The information can be included in the next version of patch set. > > > --yliu > > > > > Yes, I'd like to listen other guys comments. > > > > > > > Hopefully the virtio expert, Michael, could shine some lights on that. > > > > > > > > --yliu > > > > > > > > > > > > > > static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; > > > > > > > > > > -- > > > > > 1.7.7.6