From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id CF85E924A for ; Thu, 12 Nov 2015 23:10:42 +0100 (CET) Received: by padhx2 with SMTP id hx2so77580333pad.1 for ; Thu, 12 Nov 2015 14:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber_org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=vw/uw9+EYmSUw/EB20LEVxiAXikxhMKfWFOxJUlNGl4=; b=naoCFGuDHBuGkCvDdTjNBNTOarVqtnoepG2e3UZdEoXmws1JIjH9aArlKyOUsyJXIF JOky/oiamADFVA7t70rGR7YM5z1azQO6tMx5EjTjmuB0mj9FjXMP08RjUs/w98cMwAir hDJkThkSyo+PBSUFda6c1fEvAywh242+TVqSWOhydJVQDikqiFG3PtUXY8eCmdcO7coN tamfDHbdJCmqDRRHzoq1J6C3Jj5PUYSBO1fddLZ4fNujOAMwMM+DHUx4OqAh3x40vRyV BNC5tDVDN3qg8820pHnhbpW/BUZPXYaA1y5KwJmktCHZAgQBZv4qthTcR3jrzMEXWIGO dMoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=vw/uw9+EYmSUw/EB20LEVxiAXikxhMKfWFOxJUlNGl4=; b=jgTX1XkD1fdK3Md6Qy5IkIdt50+wlrUGKHQ4K+uGyv0CNyPcwHK1DnwfjXnJwxVdpb 2TxA89PN8a5wT+d97iLiC5w9p+SMtu73CqBdh1dMCMUboWNOwRWTmx1hKJtzNVP023ez gSMGrJ4tt/mjY1Ton4K3uu8Vg1vUKTIKP2qewHpLvmdJTLvwYzulKW21hn1R6v/oIEIe L3Whf0laLQ8TuV4iUGLD883hK5Ct7mo5WGxhFzCdYF3/XAE8c39newxkMrjPSIAw9I1C TMwYOYOtkuin9CNsa0z5KAs8HmSmhmKWvaGPyI51EZhhXOa+9UDHkg0mQfd1CehFKuPp OeOQ== X-Gm-Message-State: ALoCoQkq5q9PjLann4GrzEJCSMaVwWU2N4BmxMHbgzO95pnpbrvWdW/1pRXq5LmqkncscW7PXFCU X-Received: by 10.66.160.106 with SMTP id xj10mr26591331pab.153.1447366242197; Thu, 12 Nov 2015 14:10:42 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id jp1sm14371884pbc.54.2015.11.12.14.10.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 14:10:41 -0800 (PST) Date: Thu, 12 Nov 2015 14:10:53 -0800 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20151112141053.5f2f9bba@xeon-e3> In-Reply-To: <1446771879-3979-2-git-send-email-stephen@networkplumber.org> References: <1446771879-3979-1-git-send-email-stephen@networkplumber.org> <1446771879-3979-2-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 22:10:43 -0000 On Thu, 5 Nov 2015 17:04:33 -0800 Stephen Hemminger wrote: > The number of received multicast frames is useful and already > available in many/most drivers. Therefore don't mark it as > deprecated. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 1 - > lib/librte_ether/rte_ethdev.h | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 0b0bbcf..3b71c0c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2715,7 +2715,6 @@ ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > stats->opackets = hw_stats->vfgptc; > stats->obytes = hw_stats->vfgotc; > stats->imcasts = hw_stats->vfmprc; > - /* stats->imcasts should be removed as imcasts is deprecated */ > } > > static void > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 48a540d..f653e37 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -204,8 +204,7 @@ struct rte_eth_stats { > /**< Deprecated; Total of RX packets with bad length. */ > uint64_t ierrors; /**< Total number of erroneous received packets. */ > uint64_t oerrors; /**< Total number of failed transmitted packets. */ > - uint64_t imcasts; > - /**< Deprecated; Total number of multicast received packets. */ > + uint64_t imcasts; /**< Total number of multicast received packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */ > uint64_t fdirmatch; > /**< Deprecated; Total number of RX packets matching a filter. */ I am okay with removing imcasts if all the drivers that support provide the same information in xstats.