From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2F3675A92 for ; Tue, 17 Nov 2015 14:25:57 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 17 Nov 2015 05:25:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,307,1444719600"; d="scan'208";a="822143468" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga001.jf.intel.com with ESMTP; 17 Nov 2015 05:25:47 -0800 Date: Tue, 17 Nov 2015 21:26:36 +0800 From: Yuanhan Liu To: Tetsuya Mukawa Message-ID: <20151117132636.GU2326@yliu-dev.sh.intel.com> References: <1447046221-20811-3-git-send-email-mukawa@igel.co.jp> <1447392031-24970-1-git-send-email-mukawa@igel.co.jp> <20151113053215.GN2326@yliu-dev.sh.intel.com> <56458828.7070009@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56458828.7070009@igel.co.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH v4 0/2] Add VHOST PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2015 13:25:57 -0000 On Fri, Nov 13, 2015 at 03:50:16PM +0900, Tetsuya Mukawa wrote: > On 2015/11/13 14:32, Yuanhan Liu wrote: > > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: > >> The patch introduces a new PMD. This PMD is implemented as thin wrapper > >> of librte_vhost. > >> > >> * Known issue. > >> We may see issues while handling RESET_OWNER message. > >> These handlings are done in vhost library, so not a part of vhost PMD. > >> So far, we are waiting for QEMU fixing. > > Fix patches have already been applied. Please help test :) > > > > --yliu > > Hi Yuanhan, > > It seems there might be an another issue related with "vq->callfd" in > vhost library. > We may miss something to handle the value correctly. > > Anyway, here are steps. > 1. Apply vhost PMD patch. > (I guess you don't need it to reproduce the issue, but to reproduce it, > using the PMD may be easy) > 2. Start testpmd on host with vhost-user PMD. > 3. Start QEMU with virtio-net device. > 4. Login QEMU. > 5. Bind the virtio-net device to igb_uio. > 6. Start testpmd in QEMU. > 7. Quit testmd in QEMU. > 8. Start testpmd again in QEMU. > > It seems when last command is executed, testpmd on host doesn't receive > SET_VRING_CALL message from QEMU. > Because of this, testpmd on host assumes virtio-net device is not ready. > (I made sure virtio_is_ready() was failed on host). > > According to QEMU source code, SET_VRING_KICK will be called when > virtqueue starts, but SET_VRING_CALL will be called when virtqueue is > initialized. > Not sure exactly, might be "vq->call" will be valid while connection is > established? Yes, it would be valid as far as we don't reset it from another set_vring_call. So, we should not reset it on reset_device(). --yliu > > Also I've found a workaround. > Please execute after step7. > > 8. Bind the virtio-net device to virtio-pci kernel driver. > 9. Bind the virtio-net device to igb_uio. > 10. Start testpmd in QEMU. > > When step8 is executed, connection will be re-established, and testpmd > on host will be able to receive SET_VRING_CALL. > Then testpmd on host can start. > > Thanks, > Tetsuya