From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 86E9C5685
 for <dev@dpdk.org>; Fri, 27 Nov 2015 17:15:13 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 27 Nov 2015 08:14:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,352,1444719600"; d="scan'208";a="608161373"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.61])
 by FMSMGA003.fm.intel.com with SMTP; 27 Nov 2015 08:14:47 -0800
Received: by  (sSMTP sendmail emulation); Fri, 27 Nov 2015 16:14:46 +0025
Date: Fri, 27 Nov 2015 16:14:46 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Message-ID: <20151127161445.GB27472@bricha3-MOBL3>
References: <PATCH>
 <1448640460-25249-1-git-send-email-bernard.iremonger@intel.com>
 <1448640460-25249-2-git-send-email-bernard.iremonger@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448640460-25249-2-git-send-email-bernard.iremonger@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the
 ring_pmd_autotest program
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2015 16:15:13 -0000

On Fri, Nov 27, 2015 at 04:07:39PM +0000, Bernard Iremonger wrote:
> If eth_ring vdevs are created from the command line with the --vdev option,
> they create there own rings which are not shared by other vdevs.

Typo: s/their/there/

> Some of tests in this suite require that the vdevs share rings, so some
> of the tests fail.
> 
> For vdevs to share rings they must be created in the test code with the
> rte_eth_from_rings() function using rings created with the rte_ring_create()
> function.
> 
> Use the command line option --vdev=eth_ring0 to create port 0.

As I understand it, this option is not mandatory for the tests to pass, it only
allows some additional functional tests on cmd-line created rings to be run.
This should perhaps still be called out in the commit message.

> Create two rings and five ethdevs in test_pmd_ring.c for ports 1 to 5.
"... and then use these to run the unit tests on the pmd ring functionality"


> Improve test output by adding the port number to printf statements,
> and adding a printf describing each test.
>

/Bruce