From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 2D2C48D86 for ; Wed, 2 Dec 2015 20:45:49 +0100 (CET) Received: by pacdm15 with SMTP id dm15so49342884pac.3 for ; Wed, 02 Dec 2015 11:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-type :content-transfer-encoding; bh=iC8c+ETptrhZ07QrK6eyu7fWCaviGtCjsd4JBX3fK+0=; b=qzOc70xA2py0ji7fTg+HiWEO2C+fF++oXPNOX5Svc7hlihquynnC4PxO+9YcdW+FF5 F6VTQ7+tzDQBaoYiEK4yzwIS9QiKLZ9RI+BCv4QC86zkepKVAEqUU6DdoB+7mYF8ewkW 37JCwG1WddLeOSs89BHuFsVVQM8F1ajO2LcyzfQGVi1F9zrfkvLBEGgLcnRcFTpiTdT7 ovU/RJqjnBG1THhjIWBKUG2uS2tObkSBHLJSPiJogJE2gH8xcUZBH0RKG16IHQHRN4ns 7ssV06ZmZTgqG1L/y+KDzeWUG2oJKRy21UIGcdPNZtvsiWVwWfYxBQOEZIuszucYUShw MiSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-type:content-transfer-encoding; bh=iC8c+ETptrhZ07QrK6eyu7fWCaviGtCjsd4JBX3fK+0=; b=B9wb+f3ZO2+ZFOCLG7YXaW4A4cm/PVWLn6KmDrDjHKOoR6QpEcfXO0buU49WirgX5j A8RYIxjDwUXXlcULfgppqwoALdLbct0YgY23rtX+FmDScPYVAjTKmMYLzMo9aEaPmr5+ GrIxO3NIsnAvjYqB1vfD3X01XiPbnQTDVTFb++4W0BM1IALjrCupepMx8jWND3zz37S4 ijHdMBtf/glUAbIeGN1WAuUMHZJgoLhucGhi+rbHmU6KOjGhLoUDqcqxbtu8sk27xLDy zro5gbrQPCNVt7vvaKx3/uL78DuPaPPnMpqEnIKnf1L1kLF9vmYNeksxqqDZJJd7ISs8 qpUg== X-Gm-Message-State: ALoCoQn7y755tYAMa1sdurV+w+y3WugEf22fLbm4EkamxJze3uZoyt0iLH/YyAinMPCRWigG4Qa+ X-Received: by 10.66.150.228 with SMTP id ul4mr7298888pab.15.1449085548366; Wed, 02 Dec 2015 11:45:48 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 7sm5948577pfb.78.2015.12.02.11.45.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2015 11:45:48 -0800 (PST) Date: Wed, 2 Dec 2015 11:45:58 -0800 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20151202114558.7980fad9@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] Aligning net/ethernet.h and rte_ether.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 19:45:49 -0000 The two header files net/ethenet.h and rte_ether.h are source incompatiable right now. They both define a bunch of constants and struct ether_addr; the effective values are the same but the structure element name is different. /usr/include/net/ether.h /* This is a name for the 48 bit ethernet address available on many systems. */ struct ether_addr { u_int8_t ether_addr_octet[ETH_ALEN]; } __attribute__ ((__packed__)); lib/librte_ether/rte_ether.h struct ether_addr { uint8_t addr_bytes[ETHER_ADDR_LEN]; /**< Address bytes in transmission order */ } __attribute__((__packed__)); I would like to just have rte_ether.h include netinet/ether.h to get rid of the useless duplication, and fix all the code in DPDK. But this will break out-of-tree source compatibility so best to wait for DPDK 2.3. Is there a good place to put this in 2.2 release notes?