From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0074.outbound.protection.outlook.com [65.55.169.74]) by dpdk.org (Postfix) with ESMTP id 1926395B4 for ; Mon, 7 Dec 2015 15:33:35 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.337.19; Mon, 7 Dec 2015 14:33:28 +0000 Date: Mon, 7 Dec 2015 20:03:05 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20151207143300.GA20063@localhost.localdomain> References: <1449417564-29600-1-git-send-email-jerin.jacob@caviumnetworks.com> <1631625.Dg38D5sl3P@xps13> <20151207072644.GA3950@localhost.localdomain> <1624480.dTEes5qyS3@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1624480.dTEes5qyS3@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0023.INDPRD01.PROD.OUTLOOK.COM (25.163.198.158) To BLUPR0701MB1716.namprd07.prod.outlook.com (25.163.85.142) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:K/4d80Z2l7V1r9BrAfs8zclYft6UUWJnwfJb8wwI+DDhQ9sqNLPYX0rY78ZPR/Tlfpxi0LDFu6oQrcT6qJ1Chk1DjY+/8OowZvSaJWHoksbwQpjyOfFlsY5ppBi9mAkifqSSwj/BPUafyPfE4rJXog==; 3:f6aAcqr6/3uJHAokGikdwpyAohhLsGzW098GoODHQOpoNfmxMiC62kLlYgovllH4NFSeRN7j+f2VQ1K9Yo0T7zDTD1qGS8EfLZbENb9qUKC0kU41Pez29uW0A0r7pHsZ; 25:ocNjmVpZybhIClV3QYcpBoS9cnnSbT2J5TYxRBqa9Qwx3qaMh1PH29reff7GvR/sscpUh3r3UCHdCCw24ShSGbqJdd0Huok1ZKQtGuO3cSdX7O8LRPw0wNcdLaMULrb5HPr/pQg/vVcRJsOe3gtlkmTWHmIC5TGyLDOBbGoOeo06wWcGTEHayz5vnefnfREZy1SKBBND1Fbb/4JPlb/5bFz3Cu3+ZXWrNiIMnc/4uY7AnY0dcXY4XzJu8QeIqzpvRJVqrZ9qGRYRUWMl60usWg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:Ws50hA2wvq4t/GCry38sFRVzgJ8qUeSZU52jrR1P1wF9M55dI5D6/yzZsTQ69e20BW9EN40mHqIC9oHu0B2hRuTfTPkY5DY8wt4fw2R8qBamSlI9/srhjAIwEEj2YK/mVnEsmvUxYEiWhAA8dsw7Ya9u0iww3PVVv5kQYf3DxKje06USaAyv5/o0NqtuLY7aTfIe1CIOfBH1IVD5TlOBKXe9h0LWFXYiH41zzXLRn8M6ePVzxWykiX9CG2HV0J6bCFD5wMwrFv0vfPDN3p5Ji/giEPvrLBGp46eS5KTAueZb2qR/cdeu4TSjMKSNVssvaGHsBb8nEMTJAObc65QWsRHu0tp4JIEGYWAKHwaOYS1FPh4wnmQNZ6NhGRQH1wQqLtMD5cs3nm7a6v+jJ8wjmQHaGuuBUHC5o82DVbXACGN5R11Wq6JLGPglM9wJq74OjoSQDeYtQ1SB5MbwFeCKrx9sjtWxCujJdd/QmeuZ+XL2JSwEIVlMP2kCRnY/CD/C3Yq1H78UUZyqx67ghP93dzh/+fIA2CtlxrAl9ObtNM/0BKKa8i+jhQIxTIb4xuM9YbTmV5gmttrWgvedZYxblMqLzg6L2Wq9jgNSdJlaOMs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:h1wr9fRzjV2rslAKiEXNSuIJD6FjJ2F50RsV1zM5me99UJP8yjnTOY/jMCvXqCcTNqKCSl54plvqkrWHNZ1Syse4uq0T/jJzfLcnwBQF6pPbE0UINhQQ0uhPqXXF+5TzGfXKtDNnJFzZdIY17oimQnLKtuxEnwFRP3ny1moN/kpnO0m/9xeRL+MVCkXUIUiRmi4w2WqDPoHRYxac81hVPxQp/Xx/7ccQWYC712/W8jW99NuiRZSxF8El820h6rrkoZr5/t/BfoRgR4wyDpPYEniq0CxTMVlVwhlv6V/bg4BzR0CXcstEWynwceEkml+IqMWBbDeGUKEDbv79ybNO34si1W5F2Z8q4AgJOXifn60BtqSfBA+h0YJCm9lDLCHS X-Forefront-PRVS: 078310077C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(24454002)(199003)(189002)(377424004)(61506002)(15395725005)(66066001)(19580395003)(50466002)(47776003)(106356001)(1096002)(83506001)(42186005)(105586002)(40100003)(87976001)(101416001)(5001960100002)(23726003)(122386002)(189998001)(33656002)(3846002)(92566002)(110136002)(1076002)(76176999)(6116002)(15975445007)(54356999)(97736004)(81156007)(97756001)(77096005)(4001350100001)(93886004)(5008740100001)(2950100001)(46406003)(50986999)(5004730100002)(86362001)(586003)(5009440100003)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:lKIDPI/brvrpDQJKdQ1ZTrxm+qdDmFxfE3H/ykd?= =?us-ascii?Q?Gt+NmcTkkpUlMX7IFhSgn1loJFHJxl0yxc9aQWWXxe3aBPSDdKCLtXFx5NtB?= =?us-ascii?Q?4fWS/oUw5NNVXMgK617MVoJiz9Qt+IuagKShLNIasdBSKHncBgsguuazpdjZ?= =?us-ascii?Q?A8U/NRbrlKuylyQWWhD87rOWi9RW5whyq/83ttIucAU9qnRqPDepTsglx8Sb?= =?us-ascii?Q?GJ9SogUvxaWi+7U1P7Kt07PaG9kGNc+4+GtkwPURivOYIUroejFrrD/zeJnz?= =?us-ascii?Q?VKo57A5b78DVSM/5VX1ZbRafzohYfvCIVoBhUtwcYfFxxCHFSldHhL4PvUCA?= =?us-ascii?Q?35aTXpuH16xT7sY9QZBC0RCa49abqnNxLqoMScCndthqUQkOg3TJuBG0AxL3?= =?us-ascii?Q?30DRG4Hw2p28cwvvicUYpKGoqQBEFvV3i1xUo/Eo7bg2g738+clr7aBXxq19?= =?us-ascii?Q?gv+eU0nTZJRFUKEoifcRYnUM5GewhCVBvRdAT3z5hNy83oEAkQwSFriijla3?= =?us-ascii?Q?vwIMxbnPd/weFfquVavLhCnEe/kibdhgydcbJjj7LLA3mSDHaGgWSEiGXFmm?= =?us-ascii?Q?T83cVen3Uj/1kUPswhqWVFW9clErEXS4Lxv8ULGxiEQerMNwMGOBC1KqxPpo?= =?us-ascii?Q?whIKCy5iWoDWxxk4lHtijgCtbuCSZMtH/TuGfeGGj4JJu5zAb49XygU0kLjj?= =?us-ascii?Q?OWtz8ZSsShLUwGn4QACnaC1TTgiTCqQnogkrNc5yGa8aSoHZRn9HHZ4PfDtm?= =?us-ascii?Q?naWg9dUznBxRuc+C9lH5L2sSRk+LyDehBmQasSEFunZiE684KMycbLkbNpsG?= =?us-ascii?Q?eKmuCxncaNFIdLK8OtQXkgPfFFBzsGF1whse5/RLcABd7BeIbIhg33iSQS9J?= =?us-ascii?Q?tnu7AZFWXnIjQNPWiRH6EQr9PSRzJnnlg4Zpf/Fgp35OuWMi8dzxnrKeYWn0?= =?us-ascii?Q?prGfiDbTh1TsPzIHbZmOtn0VJhRDuNDPcnnJbopmkiqYn1GuQadyVXj2ragH?= =?us-ascii?Q?8GUIjIor/GTmIXR0a2Q8weqQLBDOjr6d11hgRBUqhYAXINOQS+NhGT0z//vx?= =?us-ascii?Q?EvbXsfwocSCF9uOILPQVk8fUpATlz6VjZqQ2RCwxriZ4ePriOvvxwDKEJ6hE?= =?us-ascii?Q?uuKnxjiaNpz1FyMPQg0YrWAgSabO1zkaC8NlGUw15cXQkrGqzGk+qXRtxc2M?= =?us-ascii?Q?VCPoHH2SZa7QkKVVWW1x+zn2xemt3D66nW06XVgXegM7MkCPlDKnU34ghtH7?= =?us-ascii?Q?XUQbiVva3Re8Ehd7XRDw=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 5:KeP+Gy6xA8k5qG7zXHjHVfCrjt4rtM4qcMEPItEdBpv0Uyh+2pQ6rh3nXn3Ijpw3zc7T0z+C6GSEOTIK4wGMUExeghniCis/0+slEv3CJ3ReC9xsaa04JI+KIh4jw/BrD13c9d6NxtR/iiANK1ob5g==; 24:da5SYrmOwptXnjwhwttw8h5tVs9gPxy/D9YUJAnfenyBtCOSUbkTpaepDDvXip4q2D9tlQJ0X8bpyHlcP3ZF+WbnhMpQfLqQ2SoaXslin1c= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2015 14:33:28.3341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] fix performance/cache resource issues with 128-byte cache line targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 14:33:35 -0000 On Mon, Dec 07, 2015 at 03:40:13AM -0800, Thomas Monjalon wrote: > 2015-12-07 12:56, Jerin Jacob: > > On Sun, Dec 06, 2015 at 05:30:50PM +0100, Thomas Monjalon wrote: > > > 2015-12-06 21:29, Jerin Jacob: > > > > This patchset fixes performance/cache resource issues with 128-byte cache line targets > > > > found in mbuf and bitmap DPDK libraries > > > > > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on > > > > 128-bytes cache line size target. > > > > > > When introducing IBM Power8, we failed to clean the cache line size definition. > > > I promised to not forget this issue in this thread with Neil: > > > http://dpdk.org/ml/archives/dev/2014-December/009439.html > > > > > > It is defined in > > > config/defconfig_* > > > mk/machine/*/rte.vars.mk > > > mk/arch/*/rte.vars.mk > > > rte_memory.h > > > rte_kni_common.h > > > > > > It should be defined only in the config files. > > > When we will introduce a configure script, we should be able to detect it. > > > > > > Please Jerin, as ThunderX maintainer, may you help to fix this old mess? > > > > Yes Thomas, I will takeup this issue when we will have configure script. > > I thought we could start setting the value in only one place. > The detection in configure script would be another step. OK Thomas, I have sent the cleanup patch. Please review it. Jerin > > > apart from that, content of the this patch will be still valid > > as the fix going to be generating cache line define from the config file. > >