From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0098.outbound.protection.outlook.com [157.56.110.98]) by dpdk.org (Postfix) with ESMTP id 075634A63 for ; Tue, 8 Dec 2015 10:34:05 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (TLS) id 15.1.337.19; Tue, 8 Dec 2015 09:34:01 +0000 Date: Tue, 8 Dec 2015 15:03:35 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20151208093333.GA3650@localhost.localdomain> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> <1750446.FDPWrLgo55@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1750446.FDPWrLgo55@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0060.INDPRD01.PROD.OUTLOOK.COM (25.164.116.160) To BLUPR0701MB1714.namprd07.prod.outlook.com (25.163.85.140) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:qoOKh/w0DXruxO1lVAJEiKC6QmLQYVnmbxeeHcjsKzimgIBCDQyDfunHwHZbLfj7AYWQD8CUfwFdswCMVMOYdCZUiIqQ42012D7Hkt/p0Lz2j4GoMspuizY1WWvvj84Hd0B3WBw31/hBoQ3tsE5CVQ==; 3:lDgARRVDdcRM/tK96pHVBTFLa/EXQW7Te+mI4rmj82+WRrhgDDdJfh+1o3u+tBmPUGiVCw9t9gzypazBhmiIdX6vPLsTNK7yuUeWQSboWAxxQHtRhoI7NYHBL8pXd0VV; 25:kkh5cYoRYvRCk2YxVXXYeUAf2g0oE0XeovSquA38uI/yYp18YqkhRhEChAszfX0mgSvX31F+nCvJwGMucTp7DGn9+twVZjIOw8Oo5/8fsVxEVoBkBlL2q2K7Ke6VS3a3QRo+SK4VF9H/ySJdbYn9gZThJn5b5x5yKGWAR3N3hcgFVLMrKRjI3nsKUQBtkkH6v1p/wSNvDHO51WytNRINoSV5UO6yKDEz/jCSOhe3Lag7l1uHuCJ0lf3/SJftWit7lFgc81PrhQa1mUTlIfImaw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 20:wHkgM+0eEhwbfnWDk11+E22cKYJe2i+i8Mq6Tp+9r3vmTKIS0cLnpgoBFrla3M9mM1za1lZbWDOeKej28OxEdoVbCu7bLLPIo3B45Iuwy2thcKuQvHz1Vem/TQUm92QOkNB2jJGov2gOptXbWqVkkEvkbCl2eJtxDMB55YNIxstqgfW4hr8TQL/JzCT/nrjGBJrzFKUmpB3UIZLX3gQ0BZY+275q6HYR26iK7+MR0xk5qGJIt4n8Q0IQtlAvbblsvvuLjyRzQX0Odad57nmKxvA4bOfzCHhXgzlhYvS9dA9whvQqAEjUnWOtCmb6gG5dj+slS64k9ePcmKi9sLEGjzL0EocT4KGSonvZORW4Yivrm2M0xxsHthEsG3m04gOz78iKcdVv9UOWeqfpt8Trd+jDG+0Wpspn0hiHS4bb2s7grjZocmkwI4ME33t9fm+SFYEkyUvvDXozEnmIX7cQL9YkgxYyPu5VwktUrFvVZIcQGWYgXTTvh/XFBa2a91fYi5CtIHWIMRMZdagEK8kyW4KsZWUSGsY9t+1nsaFm4jARZWoPeDVr96q7Mdy9RFUfMXW/Nztpmar2siSorOeu95kjYJ5M1GP+W9orbhic6VQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236414709691187); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:w/sZ6pTQUMYsN95b6Gt1ZWvKLIzFAf86RZ7DL7JbtuaTaepHBiseEs5tT6TASfzRrrL0V8c/sSAY2oExmKQqsa16cBzu7fnA2ZaF/xJia5QrwHRufh3UtYVc+O2wVp42sYLmpIFzjTa1g20LhdvrAjTifB9aR99fTP+tYfH4VHiXt/kuZTTFLHXxUkQGLGNJp15RJx3K+OXJzd5600nOglNsXAb701V57AY6XazeraL+sp+D5Bl9dud+l6QEA3Yh+y1De+U16ZIvMvf4miMEEmXcaA8rT9pDi9oOmNbWsTpmVtCcdnA16fYsQ0cQKQ5W88JLKw6xQNMjTpfuRxAKctSHKapyGRzM2pqm84ETrHxW3oZt1hdTLvoAEDuBQzi5jCAVFGZHHEQrFSCIHY/Fzc55imQtmFlAvM25bdpaXCpSa7+G8zT/0QOfa/blBLpx X-Forefront-PRVS: 0784C803FD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(189002)(24454002)(199003)(377424004)(81156007)(4001350100001)(5009440100003)(83506001)(586003)(110136002)(40100003)(6116002)(5001960100002)(66066001)(189998001)(42186005)(61506002)(3846002)(97736004)(54356999)(47776003)(5004730100002)(5008740100001)(1076002)(23726003)(1096002)(122386002)(87976001)(33656002)(50466002)(106356001)(77096005)(50986999)(19580405001)(19580395003)(2950100001)(76176999)(92566002)(97756001)(101416001)(46406003)(86362001)(105586002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:zTZyXlYOTPChZgbt6AlRS7hhsf0QjWupEn9Pywf?= =?us-ascii?Q?+clHUoLx5Zrs2w2sirOjckoK3A+TwAwog2RnyJxXiuonz71+VfBCoh44Flb9?= =?us-ascii?Q?CuR1jxUiggzpaRPHPcsBRfQzwDHpd1PrF45cCHsXmUqv9+uiTapSxfnVheXW?= =?us-ascii?Q?imHcQhvkU2DmhIjO1jZAuBXMjXwLQ3stBh4J+nnjaRyUvqcZkWRMHfNxQVob?= =?us-ascii?Q?0zfp8ScWAcUOE0q/ijIWjS12qB+ICm+MjDPjeEvbMevibG1NsmL6IVIYGM89?= =?us-ascii?Q?2R64ypjtPH4ZhURY1LhALUh1bwHQkk8XuhSK029zuh8oJd18xvjKP2m+HdX3?= =?us-ascii?Q?WSkcty59Wh0Mlt+nFI9qp2OA58ciE4EwnVipZEn3FqbRPSOhqOEntfckzktv?= =?us-ascii?Q?7tF5rMQNkxMT3F2J5apv7FLYlUJPkUSDX2UhQULq1kBv9NceYEvdJmwJtKN2?= =?us-ascii?Q?laEAhaiLr0W8TnOK4vc61avSAoY1BpEgnqDPrRXuDTTDO5oX9tDH++AQviDc?= =?us-ascii?Q?eV2+v7o41nz12S0zXbdu3JZMUpRXE0xu8U+YtILagkwK1eYkUAEWYvXGoBB2?= =?us-ascii?Q?4+QQK+wzs4tzsziNWJ4oCXUlKSN0cL0AaGVi4C1zjYGAfKLwPE1WBFVY5QrA?= =?us-ascii?Q?O2pva29nBEgHr22WADRkgZYOID+NTRVInd8CuoDNOowvodTSW8ox4xu1LSnU?= =?us-ascii?Q?1v5ewHQcH5gE6MaSzxwYWmaWSJgEqFNX7GcVfKfSUgT7wqDIepcL63Tl7nhB?= =?us-ascii?Q?v27fFevniot6QJN3uMYruYWBrAiv/+arEjFY7PcAhShg3q5JL2PzyH3G93E4?= =?us-ascii?Q?mHQ52PNkYLGVWY+zwchmKbOZQ7XyVFrD4WLYFiIaiaL5jB0wbJ1EkRawq/7y?= =?us-ascii?Q?QpcKu81s8Z9uKrLhvYlA0YusRMun02K6xOYauyMTyMgCBqnYVeNBowWzdJOv?= =?us-ascii?Q?H+g346NisM3TzD2aUxE9BvDykbz7Hwnmo43JBVQ10+2Q8AufDPXfbcGfHf7x?= =?us-ascii?Q?pt41uplA+r6s6AJqP60pTzHsjAeA3LHZ6bcIT0TuItsX8ln7E4jnSf0iTvze?= =?us-ascii?Q?s/I0Axz17DYanoLL6x4lv1t56LoQvFbEftwbX+ypD/VS9rwl3zIyzgtzunlQ?= =?us-ascii?Q?2nIeyGg5lJ+eZFuXy8GFdh4zGxCmmN3aCXqIPxKMTuUWtwtAtw5VN0fcfjFg?= =?us-ascii?Q?vTd3PyzmB29isUxmJ/eiIjrWfj8QCya85HqUR?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 5:v9IGZeM75a1YfYHMmjJDSuH3y8xNniqmrdorIugDGco6AKqKppmzbCBVPtRg8xiU/lGJ6DuN5w4KQmTIyVLXLUYOYz5gIpTtAfg/mU+F2EpNgSd4GefGyhJ96HE5Ltj/1vEBxqiwf4g6Podgk2i4OA==; 24:3VMQmqlYxP2W4xKkdxa436F/eDsFcYkSGhY8LY6I/OxRxPoZPWEVElkm4JfSxvkszfFSvuNEV37uEwjPFicwyYoPJSSzObwRDtaMPvRjYXg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2015 09:34:01.3786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 09:34:05 -0000 On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > 2015-12-07 19:52, Jerin Jacob: > > by default, all the targets will be configured with the 64-byte cache line > > size, targets which have different cache line size can be overridden > > through target specific config file. > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > based on existing configuration. > > > > Signed-off-by: Jerin Jacob > > It looks good. > We are moving from a constant defined on CC command line in most cases > to a constant included in rte_config.h only. > Have you checked that the generated libraries are identical? Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte (arm64-thunderx-linuxapp-gcc) target. md5sum build/app/test comes same with or without patch. > It would be good to have a check for POWER8. Chao? > Thanks