From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E600458D4 for ; Thu, 10 Dec 2015 07:51:28 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 22:51:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,407,1444719600"; d="scan'208";a="838240153" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga001.jf.intel.com with ESMTP; 09 Dec 2015 22:51:27 -0800 Date: Thu, 10 Dec 2015 14:52:47 +0800 From: Yuanhan Liu To: Bernard Iremonger Message-ID: <20151210065247.GT29571@yliu-dev.sh.intel.com> References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> <1449681518-27656-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449681518-27656-1-git-send-email-bernard.iremonger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample Application guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 06:51:29 -0000 On Wed, Dec 09, 2015 at 05:18:38PM +0000, Bernard Iremonger wrote: > correct sample console commands You'd state what exactly this patch corrects here, and why is that needed. > > changes in v2: > remove "user@target:~$" prefixes in command lines. > use continuation character to stay within 80 character limit. > wrap sample python code. > > Fixes: d0dff9ba445e ("doc: sample application user guide" > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > Signed-off-by: Bernard Iremonger > --- ... > > @@ -386,13 +386,15 @@ Running the Sample Code > > .. code-block:: console > > - user@target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir / mnt/huge -- -p 0x1 --dev-basename usvhost > + ./vhost-switch -c f -n 4 --socket-mem 1024 --huge-dir /mnt/huge \ > + -- -p 0x1 --dev-basename usvhost I don't think that's a right "correction": vhost-swtich would fail to start: EAL: Error - exiting with code: 1 Cause: Cannot create mbuf pool As vhost-switch creates more mbuf than 1024M can hold. However, I do think that adding this option is necessary, otherwise, all hugepages will be allocated to vhost-switch, leaving no memory for starting VM at all. (And this is kind of informatin you need to put into commit log). And limiting it to "1024M" is reasonable as well, so that we can run it on a desktop (or laptop) without too many memories. You just need fix vhost-switch example to not allocate too many mbufs by default. --yliu