From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CD049567E
 for <dev@dpdk.org>; Thu, 10 Dec 2015 13:58:00 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 10 Dec 2015 04:57:49 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="838440813"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by orsmga001.jf.intel.com with ESMTP; 10 Dec 2015 04:57:49 -0800
Date: Thu, 10 Dec 2015 20:59:11 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Message-ID: <20151210125911.GV29571@yliu-dev.sh.intel.com>
References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages
	needed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 12:58:01 -0000

On Thu, Dec 10, 2015 at 12:19:31PM +0000, Bernard Iremonger wrote:
> Change MAX_QUEUES to 128 to reduce the number of hugepages required
> by the vhost-switch program.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  examples/vhost/main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index b30f1bd..8fb0adb 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -1,7 +1,7 @@
>  /*-
>   *   BSD LICENSE
>   *
> - *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> + *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
>   *   All rights reserved.
>   *
>   *   Redistribution and use in source and binary forms, with or without
> @@ -53,7 +53,8 @@
>  
>  #include "main.h"
>  
> -#define MAX_QUEUES 512
> +/* decrease MAX_QUEUES from 512 to reduce number of hugepages needed */

Minor nit: I would suggest to simply remove this comment, which might
be a bit confusing without the content (that 512 would let vhost-switch
fail to start if given memory is small).

Otherwise, this patch looks good to me.

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks.

	--yliu

> +#define MAX_QUEUES 128
>  
>  /* the maximum number of external ports supported */
>  #define MAX_SUP_PORTS 1
> -- 
> 2.6.3