From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id D3596559C
 for <dev@dpdk.org>; Thu, 10 Dec 2015 14:32:47 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 10 Dec 2015 05:32:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="858076932"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by fmsmga001.fm.intel.com with ESMTP; 10 Dec 2015 05:32:46 -0800
Date: Thu, 10 Dec 2015 21:34:09 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Message-ID: <20151210133409.GW29571@yliu-dev.sh.intel.com>
References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
 <20151210125911.GV29571@yliu-dev.sh.intel.com>
 <8CEF83825BEC744B83065625E567D7C219F8ED41@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8ED41@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages
	needed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 13:32:48 -0000

On Thu, Dec 10, 2015 at 01:26:14PM +0000, Iremonger, Bernard wrote:
> Hi Yuanhan,
> 
> <snip>
> 
> > >  /*-
> > >   *   BSD LICENSE
> > >   *
> > > - *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > > + *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> > >   *   All rights reserved.
> > >   *
> > >   *   Redistribution and use in source and binary forms, with or without
> > > @@ -53,7 +53,8 @@
> > >
> > >  #include "main.h"
> > >
> > > -#define MAX_QUEUES 512
> > > +/* decrease MAX_QUEUES from 512 to reduce number of hugepages
> > needed
> > > +*/
> > 
> > Minor nit: I would suggest to simply remove this comment, which might be a
> > bit confusing without the content (that 512 would let vhost-switch fail to start
> > if given memory is small).
> > 
> > Otherwise, this patch looks good to me.
> > 
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > 
> > Thanks.
> > 
> > 	--yliu
> > 
> <snip>
> 
> I will remove the comment.
> Can I keep your ack.

Thanks and sure, you can always keep one's ACK if you just need fix
some minor nits when he has already given the ack.

	--yliu