From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 54A278E7B for ; Fri, 11 Dec 2015 17:33:27 +0100 (CET) Received: by pacdm15 with SMTP id dm15so67828690pac.3 for ; Fri, 11 Dec 2015 08:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ZUSWH63Ajqwrd9xK3E4/6Yn8CPNhnZyz5DxY8Xf08b0=; b=IuDWZd02r7IW2yioN8JhkkSoAkKCbYN8xmURIq5ufCvITgNH53tJscaMcpIHtC8amQ RfpVMExsC/X52DXqnudFup9t7NKAUTGKLZ++nBMi3kU85U734zdeYYdmaIYxoMaObtMF 0zKUBPxNigh1oyT3lW+RmRr5ZuFw1TWGBhqDbZnyujwYqIPIKEdCrps7SCPICepkBux3 zARZGaKVYlZMFTCRM4IYbkx58QJZisqm3ncRBjZpBDlLGp1mV76PPYZ6cBwcJQQhjmE6 GgUIID8chVJDv6DLRVvb9zOsW9yA1mFTV7B2glaRqDr6JUfYntlRlVBvT7D26PFlyai8 ckLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ZUSWH63Ajqwrd9xK3E4/6Yn8CPNhnZyz5DxY8Xf08b0=; b=FVaqf3ht2/YrXE/dvfdWpu2PgZz6Lax+i/VK0jQvQ1evGVKogx42PGFKpoI74O6/WU YjrUvTnBXCK6CX1iCXh5wz2I7btsWWM69lrEwbd3WFn7U12hV/cFp6+L2O2/dRJDBBg6 SSK2UhZbkNya3LkjC0C1yb+wD5NOF40O2ojYj0/pGLePrxmdHtBCpOP/51aToFkIyQJj opNOCnyH/DRrNaqdC+a9YJY6F8x3iQdlc6ARFDl2JjCjgxVz6cHGZ1qEt4xEtXjRh9GA dUcUliGuCbe1FHlDEXiujcHdSI1MQgGfCzT2CIFZDIdoSbJwQHHp701q5Y7T5ZEeOm3X pECA== X-Gm-Message-State: ALoCoQminx3AH7Tnlq4Xlzg0wyFF1wF2i218J92RiWKN+/ec4NsfMPfDYkhPSbaiTs/N1WCxiMwy0C/ax1DkmlJY5bw3tg6Vpw== X-Received: by 10.66.121.4 with SMTP id lg4mr26118550pab.22.1449851606554; Fri, 11 Dec 2015 08:33:26 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id u64sm26157559pfa.89.2015.12.11.08.33.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Dec 2015 08:33:26 -0800 (PST) Date: Fri, 11 Dec 2015 08:33:35 -0800 From: Stephen Hemminger To: Panu Matilainen Message-ID: <20151211083335.38c1478f@xeon-e3> In-Reply-To: <566A9750.7070507@redhat.com> References: <1449790022-24126-1-git-send-email-stephen@networkplumber.org> <566A9750.7070507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for rte_ether.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2015 16:33:27 -0000 On Fri, 11 Dec 2015 11:28:48 +0200 Panu Matilainen wrote: > On 12/11/2015 01:27 AM, Stephen Hemminger wrote: > > Plan to change to version of struct ether_addr in > > DPDK 2.3. The change in DPDK source is trivial but it will impact > > source compatablilty therefore notification is necessary. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 1c7ab01..8ecb990 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -19,3 +19,8 @@ Deprecation Notices > > and table action handlers will be updated: > > the pipeline parameter will be added, the packets mask parameter will be > > either removed (for input port action handler) or made input-only. > > + > > +* librte_ether: The structure ether_addr in DPDK will be replaced > > + by using the standard header file . The structure > > + size will be the same (no ABI impact), but the structure field name > > + will change from addr_bytes[] to ether_addr_octet[]. > > > > I hope there is some other reason/benefit besides getting rid of a > three-line custom struct definition. It may be a trivial > s/addr_bytes/ether_addr_octet/ change but it touches a lot of places all > over the DPDK codebase alone, and for 3rd party developers such (at > least seemingly) gratuitous renames are really irritating. > > - Panu - > It allows dropping dependency on cmdline in several places in code (by using ether_ntoa instead). The problem was a day 0 choice in DPDK to define their own struct's everywhere.