From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.Jacob@caviumnetworks.com>
Received: from na01-bn1-obe.outbound.protection.outlook.com
(mail-bn1on0057.outbound.protection.outlook.com [157.56.110.57])
by dpdk.org (Postfix) with ESMTP id 6FCBD8E7B
for <dev@dpdk.org>; Fri, 11 Dec 2015 14:56:56 +0100 (CET)
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Jerin.Jacob@caviumnetworks.com;
Received: from localhost.localdomain (111.93.218.67) by
BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP
Server (TLS) id 15.1.337.19; Fri, 11 Dec 2015 13:56:51 +0000
Date: Fri, 11 Dec 2015 19:26:33 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Message-ID: <20151211135631.GA23152@localhost.localdomain>
References: <1449417564-29600-1-git-send-email-jerin.jacob@caviumnetworks.com>
<1449765378-29563-1-git-send-email-jerin.jacob@caviumnetworks.com>
<1449765378-29563-5-git-send-email-jerin.jacob@caviumnetworks.com>
<2601191342CEEE43887BDE71AB97725836AD2A79@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AD2A79@irsmsx105.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: MAXPR01CA0035.INDPRD01.PROD.OUTLOOK.COM (25.164.147.42) To
BLUPR0701MB1714.namprd07.prod.outlook.com (25.163.85.140)
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
2:oaQY8XdAReZ5jAlJV177nPnutLFeiNRz5tbdDri6fbLKavsG2TaeGcuoNW37CAnBDdGgWdHI54syivjotZ6erRyrcEb5xueixIK/Io6svwUY0ilexq//NPR5S3UBO8vc8aZ032HoKcbpn3u2L4xIDg==;
3:kQPssxGRXL2VB34hvaDSIX3mQ1qISUHIIwZ+1ZBVt9HWKw9L20r3/FMoC0KAZaEH9wq6Zss1AEXzCRpmvovnsHulZe5B7jXle5tLPCTxIUqJ1tYlzBWGx1pOECVLGgqh;
25:AUj1kM6DaVC+u6mLMtGEYLejcA0K6uboCehfin4omqOrHU24T0CQWtwxKaJE7ZtQcq8+HQRVMnkQGAEzuhBFN1S0S0cZZtTuftasxhKtjL5GSdu5kgLXIJ6LXKFy7+YrJle6YiUXUc4yGgZab6a55qgAxfUtGiXjcKwlKMkJSOy6jweK/H32rPhdqe3koSRaCty7BLGnCgDHns1zzesHfaTdyZZfmlekhg+0YVB87Ag8WaxfuJm9mT6V4t3mRQ9JADUCnA83r6geQDS2M8/BMQ==
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
20:vXH3ptu7UowP/Pp/43Xj7MM9VkD1B0Bo1ekxYekE2U8ZvuGp5tybfve/b+1YLx6NtrXZm+z+GFhga2adBk4Zi8E9xiKoLI7rFN3uqXFixKgqjaBtDm+LGebweukUBsNZt784iwNwO9+r+Xrkd7XoSndT7P+1l2bk/XiNHFBMjZYbUMdQ6rish9MVSoXeZGvs8HatuPtMoNfNrdqGkJoslVDOvMTiDCatktaNyQiELT0AHLkBcdTpVsIg+ApJIO+IR0rZKls3ihxXnqpsEHmmmH7cYWzNLjnVntumxWgzfpiesOTkpbDygAcHEbCcmsWy9WTVcZ3lZLiz6QG+D4TI/ZmtcvzD3hC9I8oJBG8vojOpZ+UHO5jKGYy27dA6U11BAeFQI+eG6phltx92mR+qDfP8TutQLTmHewr0lhPMWmWZEORjtlW5WDtNQDB54+34NrdPZW8Idz7S25zv/NLnaUKd5m/XU+Lp39bYKNlNKv/li+9mavToYG2w7tRinmNsZwxyZoZF4AjRvibDb58LfDDKQRq3pSU+mwnHonsPdK08PbYFGeNVwSDR0md9ncEyo4smVkNyzukXTMoZO9Gh0NV79efmIC7i7B+oX42ZiCU=
X-Microsoft-Antispam-PRVS: <BLUPR0701MB1714B43B019FFCFB41C8360C8CEA0@BLUPR0701MB1714.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(236414709691187);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);
SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
4:Nt+Whmd+AVdc5t2Ws+9G6Ni405od6iYHQUxVgtC9fCKHIEY93pUoIbT2XOPvRmAganZDVlhExjsCJucJbL4x4is44CK8VQL+vp4/mitKvVReRNu9J35HlF4Bf/V1dwKfCmjleSX9DGQztYI5JPuphuJjBYq0bqnTXdwMEZtzZEc1R7FZDXhi4ldavkOp+qU7DMEYQ30oaWGXAz6PF689Utzw0XOFVGX9bbNHI9utzKrmce42kpV/kIMa3dxAIF6bqxaTfp/kR1b55Log1v3BZZD49XxXn17EpQW3OITrVJY7qT+ZToBysO9IrNsHWI3e96l3gVJ5CRsso0FoUCyAdXmYMLbk+qx5/UXwmcN9hsT4yaWBWmDrGaUz5CUyiLcrkFzgecf5UF09rcNVFXK/1G5g0w7TeylBX2Yoxf1mlZ8vsLIhUMjSZ8fWSJODos2+
X-Forefront-PRVS: 0787459938
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6069001)(6009001)(13464003)(189002)(377454003)(24454002)(199003)(3846002)(61506002)(4001350100001)(66066001)(40100003)(87976001)(5009440100003)(81156007)(23726003)(83506001)(586003)(97736004)(47776003)(1096002)(50986999)(5004730100002)(42186005)(6116002)(189998001)(5008740100001)(5001960100002)(92566002)(110136002)(76176999)(50466002)(33656002)(19580405001)(97756001)(54356999)(1076002)(19580395003)(93886004)(2950100001)(106356001)(77096005)(86362001)(101416001)(105586002)(46406003)(122386002)(7099028);
DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:;
SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received-SPF: None (protection.outlook.com: caviumnetworks.com does not
designate permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714;
23:KSO0ikp2q7omIq4xGiWQpmEdkhJkrzVo9dFIWvO?=
=?us-ascii?Q?Vp7tNL5WKkfPYTV0MRvvs84FNfvs/QuVaEN/T0V6EDwtGrGkMeepMHuwC9du?=
=?us-ascii?Q?VUe47Pf8btBTd9NodPXr/MIa6i8wiNW0kIOK5/iwnOxdp76MgfoCbyEdqxIl?=
=?us-ascii?Q?B87gyXUhqqgvPxt70tnQ2zFKBCaS5gT1e080eTAzzHZSiUV6xkEBC+UZxlcz?=
=?us-ascii?Q?KYoC488mCkwCcOmzo2wT0E+i4Hna6NKaDW0JDmM7q94BUukXzzzVixUkwNhR?=
=?us-ascii?Q?qQmcVeD+Q7MUC8hgFPiZsiUNXzXFBvemqdp1qHfVyFu2PsjsAAaKF5PQmxNa?=
=?us-ascii?Q?G9liaVamviTXHB8boABCFCDAeJW47mQ5g8fwRnUi5A5a8h6x9ADyCOcDzZVX?=
=?us-ascii?Q?vZEbUYAixbZqx4yCuyyIi0tLiegPzRuvIDt1hViLa9+Rf+j0kz7cJeeScJdD?=
=?us-ascii?Q?VES/PYzLrFsCvUpe5fiGkNphMsw3B3uH19NSsd4sHRsjVoZ2cHEXKXzBtfZk?=
=?us-ascii?Q?ZOXXTiVEUWypQf4phNcmR+1wrx6Z9w9/iqmQ2QF+PJQUOnqhHYLTSSXOckVR?=
=?us-ascii?Q?NK4RI1X6nSs25yJNzHpXt0YrKW7Gh76rcBrnf615AeugecAV49PYLoVRUTSR?=
=?us-ascii?Q?MNLdPgIN0f5YE7rn1LsrGlNGCtWls0G33LZzItMv1P2r7YINcAQ6SGscU1gp?=
=?us-ascii?Q?ZSbQkFfzy6nqh31z2P1x/dT54897mDz8ZJWf7seJkf0EQgdY6k16dngxG6ZA?=
=?us-ascii?Q?EN7j4ig+8dBFAtYgbQ7kfhzx3lf0kzMkD8CM3gmyXp1/lv0QO3KBjk1jNxog?=
=?us-ascii?Q?HsntkQL3vs9rhmRB5cB7oYf9kJn4C+JcJ4kEne/CFknA3ttltTiJ+uaGmHXJ?=
=?us-ascii?Q?M6/xfwPc2vpv8bo/c5+LJQN5l1S9ROH00OZUdgnnuQ8XeKEDuKroJMPbo8PL?=
=?us-ascii?Q?ccsqGtvm4WgU/amavxqFhG6yKv6NUrWIKGs+CepRbwVP+zDdZsECbpRdrL/K?=
=?us-ascii?Q?Qgdx32hY4EfjfTChBxwovQ6iMBC8XDGrNseGXKCdfE4qF2+XaETi+8mmPddd?=
=?us-ascii?Q?39Map/4IIHTzAjikM36G5EucuaOt7gD6PMP6s82+5wBuQ6XvtL4IJGh6ZElx?=
=?us-ascii?Q?d6+me3s12rZ1cz/IRkNde1CD28zP60CoBV5QCeYIxzRGkOH+tQ8BwGjuNkLD?=
=?us-ascii?Q?zpHrTntrE7sTGIJ/MtXWPts9rInnAM/mxLyDUxHj/QEc7CMihdMZqlSI42a4?=
=?us-ascii?Q?FX4alrHAsK46/iaR8P6g=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
5:QsvPed3zAu3TG+0ONJnwt0v5/F/peqmMNUSPv8Q5Fc81HiqyGQrReRKGa2WsXzg7WHN2KeJuYZc3DHmygpaS70cI0cE7ZRXaqmeEr6WqE/mlyAwVZ2zTen7TCDgpikJITh5yhqHkkZXsWXjl9yrqtw==;
24:Te0aSNy7n07SFEt0ht+IIOfTBh2/t/0FYUw2/YAcfzIr+z3c6AOUMiiSf6L+6nH1JVYTo7OS4v6auf67sH8Fboz5KQpcle5+qjZj5s6770c=
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2015 13:56:51.7754 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align
requirement for 128-byte cache targets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 13:56:57 -0000
On Fri, Dec 11, 2015 at 12:55:57PM +0000, Ananyev, Konstantin wrote:
> Hi Jerin,
>
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Thursday, December 10, 2015 4:36 PM
> > To: dev@dpdk.org
> > Cc: thomas.monjalon@6wind.com; Ananyev, Konstantin; viktorin@rehivetech.com; jianbo.liu@linaro.org; Jerin Jacob
> > Subject: [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets
> >
> > slow-path data structures need not be 128-byte cache aligned.
> > Reduce the alignment to 64-byte to save the memory.
> >
> > No behavior change for 64-byte cache aligned systems as minimum
> > cache line size as 64.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > lib/librte_ether/rte_ethdev.h | 4 ++--
> > lib/librte_mempool/rte_mempool.h | 2 +-
> > lib/librte_ring/rte_ring.h | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> > index bada8ad..4dbf73b 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -863,7 +863,7 @@ struct rte_eth_rxq_info {
> > struct rte_eth_rxconf conf; /**< queue config parameters. */
> > uint8_t scattered_rx; /**< scattered packets RX supported. */
> > uint16_t nb_desc; /**< configured number of RXDs. */
> > -} __rte_cache_aligned;
> > +} __rte_cache_min_aligned;
> >
> > /**
> > * Ethernet device TX queue information structure.
> > @@ -872,7 +872,7 @@ struct rte_eth_rxq_info {
> > struct rte_eth_txq_info {
> > struct rte_eth_txconf conf; /**< queue config parameters. */
> > uint16_t nb_desc; /**< configured number of TXDs. */
> > -} __rte_cache_aligned;
> > +} __rte_cache_min_aligned;
> >
> > /** Maximum name length for extended statistics counters */
> > #define RTE_ETH_XSTATS_NAME_SIZE 64
> > diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
> > index 6e2390a..8e5d10c 100644
> > --- a/lib/librte_mempool/rte_mempool.h
> > +++ b/lib/librte_mempool/rte_mempool.h
> > @@ -92,7 +92,7 @@ struct rte_mempool_debug_stats {
> > uint64_t get_success_objs; /**< Objects successfully allocated. */
> > uint64_t get_fail_bulk; /**< Failed allocation number. */
> > uint64_t get_fail_objs; /**< Objects that failed to be allocated. */
> > -} __rte_cache_aligned;
> > +} __rte_cache_min_aligned;
> > #endif
> >
> > #if RTE_MEMPOOL_CACHE_MAX_SIZE > 0
> > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
> > index de036ce..33166aa 100644
> > --- a/lib/librte_ring/rte_ring.h
> > +++ b/lib/librte_ring/rte_ring.h
> > @@ -123,7 +123,7 @@ struct rte_ring_debug_stats {
> > uint64_t deq_success_objs; /**< Objects successfully dequeued. */
> > uint64_t deq_fail_bulk; /**< Failed dequeues number. */
> > uint64_t deq_fail_objs; /**< Objects that failed to be dequeued. */
> > -} __rte_cache_aligned;
> > +} __rte_cache_min_aligned;
> > #endif
>
> I think we better keep both struct rte_ring_debug_stats and rte_mempool_debug_stats
> as __rte_cache_aligned.
> Both are on a per core basis and can be used at run-time
> (when RTE_LIBRTE_RING_DEBUG/RTE_LIBRTE_MEMPOOL_DEBUG=y),
> and not supposed to be shared by different cores.
> All other things in the series look good to me.
OK, I will fix the alignment of rte_ring_debug_stats and
rte_mempool_debug_stats and send the next revision with your ACK.
Jerin
> BTW, by some reason I can't find that series in the patchworks.
> Konstantin
>
>
> >
> > #define RTE_RING_NAMESIZE 32 /**< The maximum length of a ring name. */
> > --
> > 2.1.0
>