From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0099.outbound.protection.outlook.com [157.56.111.99]) by dpdk.org (Postfix) with ESMTP id 252288E90 for ; Mon, 14 Dec 2015 16:56:43 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.167.202.21) by CY1PR0701MB1726.namprd07.prod.outlook.com (10.163.21.140) with Microsoft SMTP Server (TLS) id 15.1.355.16; Mon, 14 Dec 2015 15:56:38 +0000 Date: Mon, 14 Dec 2015 21:26:07 +0530 From: Jerin Jacob To: Santosh Shukla Message-ID: <20151214155603.GA1205@localhost.localdomain> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-8-git-send-email-sshukla@mvista.com> <20151214143717.GD30309@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.202.21] X-ClientProxiedBy: MA1PR01CA0002.INDPRD01.PROD.OUTLOOK.COM (25.164.117.9) To CY1PR0701MB1726.namprd07.prod.outlook.com (25.163.21.140) X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 2:t1PKoD0smA5ER/EHBwEW2fZK/Y3IgcXWnRvET+Ew0OYeEu834OgVY2RQCOMje5F4JzIo7MY0BHCeAbJxTdHvswm3awJQ2S+HUP/qVG9yV4kfLbrc+KXANsyCB04QNZHTf6MVUDzB1dTH6WbcFWz5uA==; 3:vcMoGDiRkOD6gzIZiJHL7/JVtbE6Gt3c9XpPHKMK1o8rDa0vViXhgJMqbpqhZoPtlGj/TXrQaQQe194H4ITl5AAl3nZdLXsIQghekxxopf/MOOeg/7TA4da/L+/9D3+r; 25:vQe3976w+coGTRCk2t1nrfoIKyNH8r1sW+I0MUVAvWhsIUP+/CW0XVCo6/oStlG4NaqkfIuIsdBoNNhOS1Pb8O46YL/G5PBsMdj51yHOIAVIpYmJ6AqH7FFjU8Vfiqykd7rkORaeLbgk2RQojQnTUgzKAgFHm0fvVsAzjzHqm2IMb2sufZt8NNVQim3wd3PJ3Et7uYAH9TkFvszFZl/0qOHO0SfXSIZoqLuNmjkWAGs2Gt8XC60XiLT/8io4npf1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1726; X-LD-Processed: 711e4ccf-2e9b-4bcf-a551-4094005b6194,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 20:fIa3r7PIv04X3gqYk1erEymESiQLQmwG4Jq5+dOkCzDLnOBCccm96ieFPoNSxY+j6B7WONrKCcIYjljFG55vJ0hxeD/eMyTDVkqf9h7rsV1OBuAatrUBDIPJSrrrKzWIqMZ1DT3Ug8QKkjgkvG2RHXgwEWNdIH9poZF4uDqVWaRm7xb7YKiKtERqqbp9rCIoPYwcZMZkQlRaHDhI1x/JMy2Cyvv6tu7Fq/M5yt0SVZls2NWGeQcSuybbzCx4RDCJWIinBLO8t+wPjvynLQfa+XbOwCQRccMIPjYeWvXZ8691FEoGGxnHyhabwvq6//L7DgOIM/VGW0unF4s2IDJrVHhxE+vC+k4o2Q3wT0CQaauYrun5pvQarUQCyEbiSbiIf/2n418uXynZG5YmNEW3CQy96osEzQ+0qiaUvyM2YlV70Kd6qfqht+Sp4qsbWp4yF3PICO7UDZzBmnDIl7L9r3PUysKbxQMfq0aE5nmbZq6SPpsC72t9dnNtLtKHa3Vl0iiCA+KAg0ZWBvar97jq5xbeaDRnAiuyy7fOm7KCN58nkTsNIQ7GWrgMIdV4ZwHF+880TURjBvS4unFxe2Yg0x2wc1ITNxA3EUS2LX972cI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236414709691187); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:CY1PR0701MB1726; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1726; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 4:5pDhJE7HX4pYqdKtHGRaCtimUsDZgEx4+erENhf7aXNoSqagxUzKysT4uTEokZ8BMnpefnLOGz9p8mbQnm0KdaOFAskMM+7eT+qGTDBBJzYaaebizqLGjZbc4BjYKFlh4qJIF1ohSxmwgDUGibpPegAaOwp7BgTiaZQxxLv/IK632Brwpbt1c4lhQVNfhm/K/InKWhSD9l9yGmIbVDjD9kGRtgHGva3SGwYq2ehPFSvYSoNYRkeGl6ZtImdCXZJliuzG/Fxkr/nv0eJ5T6tVIs3bti9OPH8MKIbZuqrLtopBTr3dWX62wOfYFMl0WQSOfAMGFYcRGrSV7slu3uAYyrAfx9qy1ut/fgX0paA1TSdN5FfIDITMNP02vYFcHPVKve5sTLmqP0o7IKcjEOULk5UF/QfECGhXgzRp029WBDI= X-Forefront-PRVS: 0790FB1F33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(24454002)(199003)(377454003)(189002)(93886004)(97736004)(33656002)(87976001)(101416001)(61506002)(50466002)(97756001)(19580395003)(110136002)(189998001)(76176999)(23726003)(50986999)(1076002)(5008740100001)(83506001)(54356999)(66066001)(3846002)(92566002)(4001350100001)(1096002)(6116002)(19580405001)(81156007)(77096005)(86362001)(586003)(5001960100002)(47776003)(5004730100002)(46406003)(2950100001)(40100003)(105586002)(106356001)(42186005)(122386002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1726; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1726; 23:vR8jrKyBcB6FASvV6DkkHeKTAh5dtxOnVxssWzv?= =?us-ascii?Q?fE1BPPEaIRYnqffu/9Ien7mHAivouBAOARGboeDVmLcxwEBS+hzy9Q8k/vJ3?= =?us-ascii?Q?ipZNF16M99afQDbwIKA69KdyxDR4OYmynQr3gbsQGKyDqzkK52MGcsQGbPWR?= =?us-ascii?Q?Bb+xGbtX26xYnAVFebvkMksxCR5kSJ4WBZDk653M6X1lA0rBDyZXs9pvTKs8?= =?us-ascii?Q?AzRuYYjkIX7yusJMVo2g8BrHuUUk+M8A5MGPlsE507n27aM7pjA2spLQTNsa?= =?us-ascii?Q?WojBVlVNkRU2ySIui3m8Q7/ODLSwZKuY5ThV20dG9fX+uwbRN5A+AhJ+7lUH?= =?us-ascii?Q?N+hfD9elo8f/F8UfCognIqnbwc+Q2GcOz8Rp9KzR/dhSN5RVMr8nuwhPWs+g?= =?us-ascii?Q?9wpSMu7DXNP0NExDOr6ik2hqxrx6Bwq7IA3KLqzFm1fcwCWQ6IQw5Q0mMIbM?= =?us-ascii?Q?Xs/DKOuTeHeZN+TqhbkYp11EWPxH5xG0GjVQSWGFKyVY8YA2ufqGCXm7NOxH?= =?us-ascii?Q?mhq2mkIVuWeeNYpLey8VICwvJTZkLqsiKXUpm7ewGVnC0zM9bLO7Go1CgLI6?= =?us-ascii?Q?Jz+C7UCNxf8orKzWgEEQR8XQKkXw1zwxKu0Jqthlz7f9dnMEAHAiOZcL8IYs?= =?us-ascii?Q?NJFBqHdeh27CAIWmD6/IWap5JTu9VgzDFwJJJEnqxUtPV/k9oT4qx7AIk1xL?= =?us-ascii?Q?nA0EpPJ8QFnQVTQOvtonT3YegeJuL12F/sT1uTKRrD9JPE0+AAb+XtMyTDJw?= =?us-ascii?Q?q1FfuJw9UMk/WWtN/4vHYqK6EfyzSKMVLPIQ+/K/t9pI0olwb/5GTRj7Kndc?= =?us-ascii?Q?/Fd+BApC24t6nb2iBqGPfIwFIR0VQgKrjX+simdV9QI+P/gFEeskRmT8ERqk?= =?us-ascii?Q?jImUtpTUlzNlSn9BvZ2u13/Eq+Fqgmd9GUVx3FR/eIaovI/OgGnt7+9lHrS1?= =?us-ascii?Q?2efCaXCZoPMW7GDTB9tUeWvS4d5hcxUca3ZSriMzcGrqSVeDhw2B3oO/3lGr?= =?us-ascii?Q?qS92bChyX9747JWRfb485tKvPINRo7wONW/0dqMk8kDg/bwkKwk9aCqqsGpx?= =?us-ascii?Q?xodzzZmnngJscRZC3GquC7rWA3j6Xz4+Z44KhUh4++p/veXtQKhGhHG95xku?= =?us-ascii?Q?4YM1YAJlSz5AGXTXmoZMNmuRNEwY8g3d7xdkEjcGHnhgaQ1gJa3mvwJlBEnx?= =?us-ascii?Q?KoRKtiqgaKh9m31Q=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1726; 5:L+s432szyWJov2EkCKSv0isN7JQLWPDiYH8QHiLEMWbp72UyInKwDYu+tMc1Mhz1TxJIQypfbX3d1JqkvADeT6triN2cBWMVCmTnVI9EpLDK4LmUK78DLWPsk0I48zBOAhe9mygxe3CAFF7wXwwQbw==; 24:XbsALUelMfO7zFEmVQ5rOHHfFeHeocyl5EvxIbGmfXWwsMs2UGEr+7MvcUOv67OG1CGzoA761SqOqEb2huechipEyLFMP8qnIjEbGZ7knQ4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2015 15:56:38.5676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1726 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [ [PATCH v2] 07/13] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 15:56:43 -0000 On Mon, Dec 14, 2015 at 08:54:08PM +0530, Santosh Shukla wrote: > On Mon, Dec 14, 2015 at 8:07 PM, Jerin Jacob > wrote: > > On Mon, Dec 14, 2015 at 06:30:26PM +0530, Santosh Shukla wrote: > >> iopl() syscall not supported in linux-arm/arm64 so always return 0 value. > >> > >> Signed-off-by: Santosh Shukla > >> --- > >> lib/librte_eal/linuxapp/eal/eal.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > >> index 635ec36..2617037 100644 > >> --- a/lib/librte_eal/linuxapp/eal/eal.c > >> +++ b/lib/librte_eal/linuxapp/eal/eal.c > >> @@ -716,6 +716,9 @@ rte_eal_iopl_init(void) > >> return -1; > >> return 0; > >> #else > >> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) > >> + return 0; /* iopl syscall not supported for ARM/ARM64 */ > > > > I guess for other architectures also iopl not supported.I think better > > to move this function to eal. Else this function will return 'true' for > > ppc64 > > > > didn't understood. This func is in eal right? and for ppc64, function meant to abstract through lib/librte_eal/common/include/arch/ to avoid #ifdef clutter > will return -1 (false). Although i could include ppc64 / tile or > invert the logic such a way that non-x86 arch to return default true > value. > > However iopl() used for virtio and only two arch using x86/ now arm. I > am not sure ppc64/tile or other arch has any plan to use virtio pmd > thus care for iopl(). Why not? With your patch, dpdk-virtio has very minimal dependency on architecture (implementing raw_*) or even we can have generic routine for that > > > or have at least postive logic, > > #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || > > defined(RTE_ARCH_X86_X32) > > > > > >> +#endif > >> return -1; > >> #endif > >> } > >> -- > >> 1.7.9.5 > >>