From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: dev@dpdk.org, 'Ilya Maximets' <i.maximets@samsung.com>,
'Dyasly Sergey' <s.dyasly@samsung.com>
Subject: Re: [dpdk-dev] problem vhost-user sockets
Date: Tue, 15 Dec 2015 22:04:50 +0800 [thread overview]
Message-ID: <20151215140450.GL29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <00c101d13735$e85453d0$b8fcfb70$@samsung.com>
On Tue, Dec 15, 2015 at 03:41:23PM +0300, Pavel Fedin wrote:
> Hello!
>
> I have a question regarding vhostuser. If we cannot bind to a socket, why do we simply fail with error instead of just unlink()ing
> the path before binding?
I'm thinking you can't simply unlink a file given by a user inside
a libraray unconditionaly. Say, what if a user gives a wrong socket
path?
>
> This causes a very annoying problem with ovs. After ovs is stopped (i use supplied system integration), these sockets are not
> removed. Looks like ovs just exits without correct cleanup. This effectively causes my vhostuser interfaces to go down until i clean
> them up manually. And i have to do it after every ovs restart, every system reboot, etc. It is very annoying.
> I understand that the app should really do correct cleanup upon exit. But what if it abnormally crashes because of some reason
> (bug, attack, etc)? Shouldn't it be able to automatically recover?
I normally write a short script to handle it automatically.
--yliu
next prev parent reply other threads:[~2015-12-15 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 12:41 Pavel Fedin
2015-12-15 14:04 ` Yuanhan Liu [this message]
2015-12-15 14:21 ` Pavel Fedin
2015-12-15 16:37 ` Xie, Huawei
2015-12-16 1:31 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215140450.GL29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=p.fedin@samsung.com \
--cc=s.dyasly@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).