From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 649A011A2
 for <dev@dpdk.org>; Tue, 15 Dec 2015 15:06:03 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 15 Dec 2015 06:04:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,432,1444719600"; d="scan'208";a="871912985"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by orsmga002.jf.intel.com with ESMTP; 15 Dec 2015 06:04:46 -0800
Date: Tue, 15 Dec 2015 22:04:50 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Pavel Fedin <p.fedin@samsung.com>
Message-ID: <20151215140450.GL29571@yliu-dev.sh.intel.com>
References: <00c101d13735$e85453d0$b8fcfb70$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00c101d13735$e85453d0$b8fcfb70$@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org, 'Ilya Maximets' <i.maximets@samsung.com>,
 'Dyasly Sergey' <s.dyasly@samsung.com>
Subject: Re: [dpdk-dev] problem vhost-user sockets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Dec 2015 14:06:03 -0000

On Tue, Dec 15, 2015 at 03:41:23PM +0300, Pavel Fedin wrote:
>  Hello!
> 
>  I have a question regarding vhostuser. If we cannot bind to a socket, why do we simply fail with error instead of just unlink()ing
> the path before binding?

I'm thinking you can't simply unlink a file given by a user inside
a libraray unconditionaly. Say, what if a user gives a wrong socket
path?

> 
>  This causes a very annoying problem with ovs. After ovs is stopped (i use supplied system integration), these sockets are not
> removed. Looks like ovs just exits without correct cleanup. This effectively causes my vhostuser interfaces to go down until i clean
> them up manually. And i have to do it after every ovs restart, every system reboot, etc. It is very annoying.
>  I understand that the app should really do correct cleanup upon exit. But what if it abnormally crashes because of some reason
> (bug, attack, etc)? Shouldn't it be able to automatically recover?

I normally write a short script to handle it automatically.

	--yliu