From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A83FE593A for ; Wed, 16 Dec 2015 15:37:03 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 16 Dec 2015 06:37:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,437,1444719600"; d="scan'208";a="618992771" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 16 Dec 2015 06:37:02 -0800 Date: Wed, 16 Dec 2015 22:37:16 +0800 From: Yuanhan Liu To: Santosh Shukla Message-ID: <20151216143716.GW29571@yliu-dev.sh.intel.com> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-12-git-send-email-sshukla@mvista.com> <20151216132940.GT29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [ [PATCH v2] 11/13] virtio_ioport: armv7/v8: mmap virtio iopci bar region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 14:37:04 -0000 On Wed, Dec 16, 2015 at 07:50:51PM +0530, Santosh Shukla wrote: ... > >> + *resource_addr = (void *)((char *)ioport_map + (ioport_map_cnt)*offset); > > > > Redundant (), and the void * cast seems to be unnecessary. > > > > (void *) is unnecessary, but couldn't get the redundant() part? I meant the () of "(ioport_map_cnt)*offset". > > >> + ioport_map_cnt++; > >> + > >> + PMD_INIT_LOG(DEBUG, "pci.resource_addr %p ioport_map_cnt %d\n", > >> + *resource_addr, ioport_map_cnt); > >> + return ret; > >> +} > >> + > > > Is it redundant comment or your suggesting to use : r / (void) / __rte_unused? You should always use __rte_unused instead of (void) cast. Note that you may need check your other patches, to make sure you not miss other such usage. --yliu