From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2F7578D8F for ; Fri, 18 Dec 2015 05:19:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 17 Dec 2015 20:19:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,444,1444719600"; d="scan'208";a="619944095" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 17 Dec 2015 20:19:19 -0800 Date: Fri, 18 Dec 2015 12:19:50 +0800 From: Yuanhan Liu To: Tetsuya Mukawa Message-ID: <20151218041950.GJ29571@yliu-dev.sh.intel.com> References: <1447392031-24970-3-git-send-email-mukawa@igel.co.jp> <1448355603-21275-1-git-send-email-mukawa@igel.co.jp> <1448355603-21275-4-git-send-email-mukawa@igel.co.jp> <20151217114750.GD29571@yliu-dev.sh.intel.com> <56737A65.9060603@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56737A65.9060603@igel.co.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH v5 3/3] vhost: Add helper function to convert port id to virtio device pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 04:19:21 -0000 On Fri, Dec 18, 2015 at 12:15:49PM +0900, Tetsuya Mukawa wrote: > On 2015/12/17 20:47, Yuanhan Liu wrote: > > On Tue, Nov 24, 2015 at 06:00:03PM +0900, Tetsuya Mukawa wrote: > >> This helper function is used to convert port id to virtio device > >> pointer. To use this function, a port should be managed by vhost PMD. > >> After getting virtio device pointer, it can be used for calling vhost > >> library APIs. > > I'm thinking why is that necessary. I mean, hey, can we simply treat > > it as a normal pmd driver, and don't consider any vhost lib functions > > any more while using vhost pmd? > > I guess vhost PMD cannot hide some of vhost features. Sorry, a "guess" could not convice me to have it. On the other hand, it does no harm but brings great benefit to make things simple in the first time. __If__ there really is a need for them, we could add it back, isn't it? ;) --yliu > Because of this, we may need to add ethdev APIs to wraps these features. > I described more in one more email. Could you please see it also? > > Thanks, > Tetsuya >