From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <peterx@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2F143F72
 for <dev@dpdk.org>; Tue, 22 Dec 2015 08:59:55 +0100 (CET)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 by mx1.redhat.com (Postfix) with ESMTPS id AA4A1C0B7E21;
 Tue, 22 Dec 2015 07:59:53 +0000 (UTC)
Received: from pxdev.xzpeter.org (vpn1-6-183.pek2.redhat.com [10.72.6.183])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 tBM7xaJ9005740
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 22 Dec 2015 02:59:45 -0500
Date: Tue, 22 Dec 2015 15:59:35 +0800
From: Peter Xu <peterx@redhat.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Message-ID: <20151222075935.GD7532@pxdev.xzpeter.org>
References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1450321921-27799-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1450321921-27799-4-git-send-email-yuanhan.liu@linux.intel.com>
 <20151222065552.GC7532@pxdev.xzpeter.org>
 <C37D651A908B024F974696C65296B57B4C551224@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <C37D651A908B024F974696C65296B57B4C551224@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
Cc: "Michael S. Tsirkin" <mst@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Victor Kaplansky <vkaplans@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/6] vhost: log used vring changes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Dec 2015 07:59:55 -0000

On Tue, Dec 22, 2015 at 07:07:25AM +0000, Xie, Huawei wrote:
> On 12/22/2015 2:56 PM, Peter Xu wrote:
> > Got a question here:
> >
> > I see that we are logging down changes when we are marking
> > used_vring. Do we need to log down buffer copy in rte_memcpy() too?
> > I am not sure whether I understand it correctly, it seems that this
> > is part of DPDK API ops to deliver data to the guest (from, e.g.,
> > OVS?), when we do rte_memcpy(), we seems to be modifying guest
> > memory too. Am I wrong?
> >
> > Peter
> 
> desc buffer logging isn't included in v1, but in the patch 4 of this
> patch set, and actually it is the major work in vhost live migration.

Yes, it is. Thanks to point out.

Peter

>     --huawei
> 
> [...]
>