From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id A9A298E9D for ; Mon, 4 Jan 2016 18:24:03 +0100 (CET) Received: by mail-pa0-f54.google.com with SMTP id yy13so107676445pab.3 for ; Mon, 04 Jan 2016 09:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ybxQQkq/wAE/RJxUJtosi2+4s+KT+FRRhLj74SAa2yA=; b=DvllzkkVyuzusPiFWn65wwGYT4n4hjAchtVPNA3vfpWlRfLfOm3mM0FJlBJnRv9HFl 3PlOjQCXMx5B2MF206BB+P2kt9m8psx9XcNHrfLbwkRlCxL18k2n0+07DXzBjk94THGp brWW840KRZMqLHm24VO/Kmm57gz1ogt8QaQXrD6ywkSMGOyplActQjPy+JtwBerD1Ia1 ufxxqm3vFgaynWIRcCzks0rqE9TRCLuGB0Reb1f3fqLXGDGU/oanPoiIK2679MO/XKUM QvboOrddJU5qA04sHMlattsBWGdIhAOnfcS3Rw7jMXw3bHWqkTfoOv2rRafdJvLUQMqF IPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ybxQQkq/wAE/RJxUJtosi2+4s+KT+FRRhLj74SAa2yA=; b=aWUHB4LgZ6Ca5P3C9RXBf2NOOFQBQKZ2vjCHrcOw+iaflHFtouCA30bED9kyle87Zq 2g2UDk3OMjkx+wloz4N4zaopR82mi3NU0j1R32g03MZV6Rnmn9GnFecN07W+ZiA54h0M g677hCxSG7B95CY0p+yQpM87N84gFeBRxD0CbGRjr9sF3YgcgdwbDujRgn2MYx7pyvcH ssSyLWOjx4TGV5rq0/Z1ZoNmvFBAzqnch5EEiYzBeGa92I8ITFkV+EhDcNaQAJ4tPkiD 7/+BinzWT+mDcf8UVxoPuEbEAp2h0+Oigb8xDviuCKZke9xqWZXoPU7qXmVQQtviDI1W zp4w== X-Gm-Message-State: ALoCoQn8LXg7b3MQQgS40lrvZGn87hiE5/wZ+78gENCZHySihlmSjUBIaF2FlgJhO4GztFNiLwbEiaXBmRp0KdokNEEh2vEzNw== X-Received: by 10.67.5.98 with SMTP id cl2mr128343534pad.157.1451928242903; Mon, 04 Jan 2016 09:24:02 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id g88sm87712105pfj.91.2016.01.04.09.24.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jan 2016 09:24:02 -0800 (PST) Date: Mon, 4 Jan 2016 09:24:10 -0800 From: Stephen Hemminger To: Huawei Xie Message-ID: <20160104092410.11311412@xeon-e3> In-Reply-To: <1451843773-103006-5-git-send-email-huawei.xie@intel.com> References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <1451843773-103006-5-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 17:24:04 -0000 On Mon, 4 Jan 2016 01:56:13 +0800 Huawei Xie wrote: > + if (pci_dev->kdrv != RTE_KDRV_NONE) { > + PMD_INIT_LOG(INFO, > + "kernel driver is manipulating this device." \ > + " Please unbind the kernel driver."); Splitting strings in general is a bad idea since it makes it harder to find log messages. Also the first clause is lower case and the second is captialized. Lastly, the backslash continuation is unnecessary here and will cause checkpatch warning.