From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 7865D9215
 for <dev@dpdk.org>; Tue,  5 Jan 2016 06:15:13 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id e65so160983691pfe.1
 for <dev@dpdk.org>; Mon, 04 Jan 2016 21:15:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=rmzO4k80kDCJObYMttUKY1YOWpt7jyGDLiRpYx/rwW0=;
 b=Y36CN4yMaERBl+BenAZrOOV6z4wgv3QFGLK7CkQoqeVIaeaDbBtIHTP1qyop/G0irp
 HZAuF8wRwCcwAFY6fKr3D3NhW1Bvr+MXMopPUZyvcmWeklfzGMz8F3dXQWQTqyHMY/x5
 c7oXtWnr5hrMAGQHyYR+6foKymvf3uoofFkYRTmziIz/iph4EtPCf+vq568zluaAfTQK
 N37CxBZBiBcQWm9fohja/GjOqEtE91/1KTCgGjDKl0KcjuUaFnvgEHL8exLXcitGu5y4
 9vrArBIq0FcXyPPAieboSSRXFBVkY+62onsDnLHK14KnjXZa6QMozSYq6VJYpGTCJESj
 IqvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=rmzO4k80kDCJObYMttUKY1YOWpt7jyGDLiRpYx/rwW0=;
 b=T9To8EAnycJ+pZDqR19vThMEROHMmXR1tSxoxLbgbktSzDzdh1CVnKuDfeMFZPMWYz
 CFEDMpTAEv1BpCnjAUhWuKT1qmWGQ66ZxO8+mdoqARsJ4YrL63MGHO9HOzHqx3phRtbN
 0dl/Y8tTIdyH42MkSpat0wFt1NHWd1gEdgvP7VZByLPTHTLkG+pq/CZ7miN/6KGBd2HV
 oO9aznJZ1Hgxi9v09208izlscHDEJyuAxhZDSXj0UNL1IP9nbxKUHaVYoJmyr+a2WOKl
 mY9KpyUcSvNOWeTFvt4RxHnprxGMicLjaCuOK+3Bt26MENK+T3VuGnvCw+aAdZyg+D7G
 /k5Q==
X-Gm-Message-State: ALoCoQmU0lJSH8Jx2kUKsGubYOz/yRjGgoMAnOlATHxR56J9tsuKjY3AYSyTBicXKd3yq0HXmHCaj6Jx6jqO3ECMtaWjpui68Q==
X-Received: by 10.98.14.5 with SMTP id w5mr114531136pfi.126.1451970912869;
 Mon, 04 Jan 2016 21:15:12 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id p17sm95473541pfi.54.2016.01.04.21.15.12
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 04 Jan 2016 21:15:12 -0800 (PST)
Date: Mon, 4 Jan 2016 21:15:19 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Message-ID: <20160104211519.52d76a3f@xeon-e3>
In-Reply-To: <1451960899-26881-4-git-send-email-yongwang@vmware.com>
References: <1451960899-26881-1-git-send-email-yongwang@vmware.com>
 <1451960899-26881-4-git-send-email-yongwang@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 3/4] vmxnet3: add TSO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2016 05:15:13 -0000

On Mon,  4 Jan 2016 18:28:18 -0800
Yong Wang <yongwang@vmware.com> wrote:

> +/* The number of descriptors that are needed for a packet. */
> +static unsigned
> +txd_estimate(const struct rte_mbuf *m)
> +{
> +	return m->nb_segs;
> +}
> +

A wrapper function only really clarifies if it is hiding some information.
Why not just code this in place?