From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 49CD991E9 for ; Tue, 5 Jan 2016 03:24:17 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 04 Jan 2016 18:24:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,523,1444719600"; d="scan'208";a="853591678" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga001.jf.intel.com with ESMTP; 04 Jan 2016 18:24:14 -0800 Date: Tue, 5 Jan 2016 10:27:52 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Message-ID: <20160105022752.GG26062@yliu-dev.sh.intel.com> References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 02:24:17 -0000 On Tue, Jan 05, 2016 at 02:21:12AM +0000, Tan, Jianfeng wrote: > > > > -----Original Message----- > > From: Xie, Huawei > > Sent: Monday, January 4, 2016 9:52 AM > > To: dev@dpdk.org > > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei > > Subject: [PATCH] fix checkpatch errors > > > > Signed-off-by: Huawei Xie > ... > > mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name)); > > - return (rte_mempool_lookup((const char *)pool_name)); > > + return rte_mempool_lookup((const char *)pool_name); > > Hi Huawei, > > Assume this patch is to solve below error (reported by checkpatch): > ERROR: return is not a function, parentheses are not required > > So maybe above fix is not necessary? Involve more people to discuss. This fix is good to me. > And please include the error message in the commit message. +1 --yliu