From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D72B19583 for ; Thu, 7 Jan 2016 14:18:02 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 07 Jan 2016 05:18:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,533,1444719600"; d="scan'208";a="25139322" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga004.fm.intel.com with ESMTP; 07 Jan 2016 05:18:00 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u07DHxZv016700; Thu, 7 Jan 2016 13:18:00 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id u07DHxvD013597; Thu, 7 Jan 2016 13:17:59 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id u07DHxYx013592; Thu, 7 Jan 2016 13:17:59 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Thu, 7 Jan 2016 13:17:59 +0000 From: Ferruh Yigit To: "Xie, Huawei" Message-ID: <20160107131759.GA3222@sivlogin002.ir.intel.com> Mail-Followup-To: "Xie, Huawei" , Stephen Hemminger , "dev@dpdk.org" References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <1451843773-103006-5-git-send-email-huawei.xie@intel.com> <20160104092410.11311412@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 13:18:03 -0000 On Mon, Jan 04, 2016 at 05:56:49PM +0000, Xie, Huawei wrote: > On 1/5/2016 1:24 AM, Stephen Hemminger wrote: > > On Mon, 4 Jan 2016 01:56:13 +0800 > > Huawei Xie wrote: > > > >> + if (pci_dev->kdrv != RTE_KDRV_NONE) { > >> + PMD_INIT_LOG(INFO, > >> + "kernel driver is manipulating this device." \ > >> + " Please unbind the kernel driver."); > > Splitting strings in general is a bad idea since it makes it harder to find log messages. > > Also the first clause is lower case and the second is captialized. > Got it. This is to avoid 80 char warning. Will put it in one line to > make it friendly for searching. > The first clause is lower is because it actually follows "%s():". Indeed checkpatch lets logging functions be longer than 80 chars, so does not forces to split message. But checkpatch detects kernel logging functions only, not ours, that is why we are still getting over 80 chars warning. Should we ignore LONG_LINE_STRING warnings in checkpatch? Thanks, ferruh