From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com
 [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id 426778E5E
 for <dev@dpdk.org>; Fri, 15 Jan 2016 19:13:33 +0100 (CET)
Received: by mail-pa0-f49.google.com with SMTP id uo6so383119905pac.1
 for <dev@dpdk.org>; Fri, 15 Jan 2016 10:13:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=GEs4oQRkIAxQ/F73YwiJvv3AWQPSUfP8/GLF2C4G/y0=;
 b=TvUCze0aQ7prUSgmPxVO2EBBLf2EE/brKGgJQHLJqAM5N3ZJ+6iRg06+UJu+NGDxsa
 tY/CJd+R4kR8t8EC9sD11UVvCXiOIbucF0aA74kYVKg1SOV76+0I654uwcEDao/wRkSE
 yuR881BKnssY6sIMXKHPEyzaqfqco0qJy5H/wkrGWDtRblDCGkjvisnr6Yx+5CccrhVi
 ++hGKP6dGF6beuqk3rmMz24Hk1t/60ErF7uaov1pScgSFOXANaqGhleoqczkYnB6ycE3
 kfioogmdcRJbdavPZdO+4T/MoXlxMVCKSGCI1Eb25euFHSdooUKrIR0nRruE/r/oZKo0
 H6ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=GEs4oQRkIAxQ/F73YwiJvv3AWQPSUfP8/GLF2C4G/y0=;
 b=jG6GUrKfE6IcgI/EEJvpdBlwFo10cb2y1RlzzLtyeHUraArg2W+MIS/Sorx6dG6+4t
 P5BcB98+zM8zucznMos3Ep7YBR85WhAv/sV2nYHvvHFCBbBMAgueJX2CoguXyEREPH0F
 Zf8U5hr93UxqaKcad/PxkwjG6t2JxsvNTuGlZG15Ew3mM1b701qeJItHbktu1rSS3C6E
 sut2vqLAhS4peY7aCcrhEx3OLWyXgQG65PtF8Dks0VTiktObDqCPUCpvN1Zz8Ia0rQ42
 4KQai8VU/moQ1uDcOQXr9xAhVgIdehORlJ+Cfr/5UVpRHg7lX3u0zJ8BDPekwYRyYHoU
 m/5Q==
X-Gm-Message-State: ALoCoQmyQHGbkSf9fyIwA/cphYBRod+47+0Em9UmyByTfkKNHtUmCmTLZhJUUPfBUZGZbyEWFzAb1qEjTGxiZatw87VvLW+EsQ==
X-Received: by 10.67.15.73 with SMTP id fm9mr17188661pad.130.1452881612617;
 Fri, 15 Jan 2016 10:13:32 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id wa17sm16897335pac.38.2016.01.15.10.13.32
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 15 Jan 2016 10:13:32 -0800 (PST)
Date: Fri, 15 Jan 2016 10:13:41 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Message-ID: <20160115101341.41065590@xeon-e3>
In-Reply-To: <1452869038-9140-2-git-send-email-tomaszx.kulasek@intel.com>
References: <1452869038-9140-1-git-send-email-tomaszx.kulasek@intel.com>
 <1452869038-9140-2-git-send-email-tomaszx.kulasek@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add buffered tx api
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 18:13:34 -0000

On Fri, 15 Jan 2016 15:43:57 +0100
Tomasz Kulasek <tomaszx.kulasek@intel.com> wrote:

>  static int
>  rte_eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
>  {
>  	uint16_t old_nb_queues = dev->data->nb_tx_queues;
>  	void **txq;
> +	struct rte_eth_dev_tx_buffer *new_bufs;
>  	unsigned i;
>  
>  	if (dev->data->tx_queues == NULL) { /* first time configuration */
> @@ -841,17 +872,40 @@ rte_eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
>  			dev->data->nb_tx_queues = 0;
>  			return -(ENOMEM);
>  		}
> +
> +		dev->data->txq_bufs = rte_zmalloc("ethdev->txq_bufs",
> +				sizeof(*dev->data->txq_bufs) * nb_queues, 0);

You should use zmalloc_socket and put the buffering on the same numa
node as the device?