From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id EB74C8DAF
 for <dev@dpdk.org>; Wed, 20 Jan 2016 19:35:56 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id e65so8826987pfe.0
 for <dev@dpdk.org>; Wed, 20 Jan 2016 10:35:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=tsZB1lYEXVMIGrA32CnX8bCqWkiPTd4MS2HpLHmMnBc=;
 b=eN47eej3da/+XQrcX7dmOnLLnMmS2gaCpKzmbTN6NBXVvFc+O/qACeFbP5cZd+Ea2N
 oceXNU1otSvb9286V9AOjd2zsIFvs/P99JiqOSnE4b9SFp7WJhvOa7Jj+mgP+HnRUz+0
 C+3nZyx6r3YVJZz73xcu9dqX5Vbn0cFYg7FyEeF6hQpcLdUPukXkZb41yTYiKjqZJ+Qw
 Guhfnj8SrVFZyOVklCcazrtyaaRVebkQjDxMLrIVrNhhyOn7ydHbWvKUocDY4qJUpfn5
 T9UQCwJW8+ynYN/4bq6uTbj5fTl9m6n/ZElw6Kk6hZxmpoyT1FCjAGTUWI0m63NKi5W7
 xhrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=tsZB1lYEXVMIGrA32CnX8bCqWkiPTd4MS2HpLHmMnBc=;
 b=GY5FU4ViZbILcPxIgRZWdw1E0jBsnx9O68C5SWQwOsjXNdz1Kdj00Nkbqr74s41hga
 cF7YpGekN7L4+L3/VIYtXdII8dlq0Ry7f+ZMtAArCJo6MHSvz9u9CDbpOk76b+E2dVtx
 LluPBhz5T/wdwBkSHvxyA+B84rWZOlGPbtamWUA6s/gilOBzJqTIudfbD5EgBrGWHlmM
 ZIt1iV6aY+wOAmC0Yk4N3YfV9FaXz7RHfUseIsWe1UXFKJthVD1eYar5xzhJwydZwNou
 Lm11SH97yS4sf2rD3DWP5caSE4rCjxFZO2lCN6ytgReAcqC6nLQ+nblsU0B6+Cwj7S1S
 qJRA==
X-Gm-Message-State: ALoCoQndKqDC6bTQEMahqaMQW/Y2QUyOwQD9ExUhtT7N5vFvoXD3YedJb+foepbIBuoQDov727vur0n53ZmM5jf/bEeQHQCdpg==
X-Received: by 10.98.1.203 with SMTP id 194mr55537464pfb.10.1453314956366;
 Wed, 20 Jan 2016 10:35:56 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id tm4sm50773230pab.3.2016.01.20.10.35.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 20 Jan 2016 10:35:56 -0800 (PST)
Date: Wed, 20 Jan 2016 10:36:04 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160120103604.2e32c9ac@xeon-e3>
In-Reply-To: <3240763.FVKPEEMrPZ@xps13>
References: <1453300086-3756-1-git-send-email-harry.van.haaren@intel.com>
 <E923DB57A917B54B9182A2E928D00FA61285F3A6@IRSMSX102.ger.corp.intel.com>
 <CAMFWN9kjhU7njoOEht8beZbxBWBshh44tsFvnD0HnbkVeh2MqQ@mail.gmail.com>
 <3240763.FVKPEEMrPZ@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: expose link status and speed using
 xstats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 18:35:57 -0000

On Wed, 20 Jan 2016 16:13:34 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> > We already have the rte_eth_link_get function. Why not let users
> > continue to use that? It's well defined, it is simple, and it is
> > consistent.  

+1

API's should not duplicate results (DRY)

That said, it would be useful to have some way to get statistics
on the number of link transitions and time since last change.
But this ideally should be in rte_eth_link_get() but that wouldn't
be ABI compatiable.