From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4EB0CC3EC
 for <dev@dpdk.org>; Thu, 28 Jan 2016 11:11:17 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 28 Jan 2016 02:11:16 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,358,1449561600"; d="scan'208";a="735720520"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga003.jf.intel.com with ESMTP; 28 Jan 2016 02:11:16 -0800
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 u0SABE5D002035; Thu, 28 Jan 2016 10:11:14 GMT
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id u0SABEDd012834;
 Thu, 28 Jan 2016 10:11:14 GMT
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id u0SABD4B012830;
	Thu, 28 Jan 2016 10:11:13 GMT
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Thu, 28 Jan 2016 10:11:13 +0000
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160128101113.GA9647@sivlogin002.ir.intel.com>
Mail-Followup-To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org,
 Helin Zhang <helin.zhang@intel.com>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
References: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com>
 <96929867.upEFuzBccp@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <96929867.upEFuzBccp@xps13>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: remove "extern" keyword for functions
	from header	files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 10:11:17 -0000

On Wed, Jan 27, 2016 at 07:05:52PM +0100, Thomas Monjalon wrote:
> 2016-01-25 10:01, Ferruh Yigit:
> > Remove "extern" keywords in header files, the ones for function
> > prototypes
> 
> I've seen a lot of other extern keywords. Why not removing all?
> 
Remaining one are Linux drivers in KNI, they are kind of internal headers, I doubt on touching them.
Should I remove them all?
Also there are more usage in "drivers" folder, I am not sure touching them too, what do you comment?

> > -extern int rte_eth_dev_configure(uint8_t port_id,
> > -				 uint16_t nb_rx_queue,
> > -				 uint16_t nb_tx_queue,
> > -				 const struct rte_eth_conf *eth_conf);
> > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue,
> > +			  uint16_t nb_tx_queue,
> > +			  const struct rte_eth_conf *eth_conf);
> 
> The indent is weird.
> Why not follow the guideline with 2 tabs?
> http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation

Intentionally kept them as original, to scope the patch just to remove a keyword.
Do you want me fix the syntax wherever I touch for this patch?

Thanks,
ferruh