From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0070.outbound.protection.outlook.com [65.55.169.70]) by dpdk.org (Postfix) with ESMTP id 5A225C4EA for ; Fri, 29 Jan 2016 05:25:24 +0100 (CET) Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.167.176.101) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (TLS) id 15.1.396.15; Fri, 29 Jan 2016 04:25:18 +0000 Date: Fri, 29 Jan 2016 09:54:56 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20160129042455.GA24789@localhost.localdomain> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> <1750446.FDPWrLgo55@xps13> <20151208093333.GA3650@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151208093333.GA3650@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.176.101] X-ClientProxiedBy: MAXPR01CA0006.INDPRD01.PROD.OUTLOOK.COM (25.164.147.13) To BLUPR0701MB1713.namprd07.prod.outlook.com (25.163.85.14) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:JbtEkzdJ7c3rp0wieAtb2kFXAFhWwADot0iTD4J/4BzqvIf8KO5/feIAqhSPZ1LvY0RcMrXBoTpHYjEfPlnbUbr3KT7HIjUI7qMx99TJIfSS7gf4xaQIR6OdeB7LMXRziQAg1Anceq7WR/vc+PW4Pg==; 3:SXvtwWn/rhwLweaubSM/J8nerNzdgA/rKPluxL3X+vnEdnz4wvOndtbE5/YzLNW/L8st23Wr1sjcVmvAEfo5tICnd8xwaVBn0TZ7IYANtNBTcI18bhOeQzl1TPKW/vXO; 25:a4oJYWXXTLor6TfcunUKmCUJxI/t97rDlnUkpcV57ztrh40AoBshhlDI8tUP6Uv8IVqLm3dAyJOS77+UcKdeeXo0dY2hcz6HefL71NfkWyqJKAusK/UUq80qb1KSynfFjXFFROInclzkRx+IZCOT9UvuozLq8rAskziTCSvn5SUMx8NgJlDStGk2zTWDpieTY7jmySi4+zoUxRu3+lXmKWWCVdro+LlqhSXGPwgapaB92fkc8QsIqyWSV+Afid04 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-MS-Office365-Filtering-Correlation-Id: 0e5bc557-f3b0-4085-a873-08d3286433ca X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 20:dMXuD2i1qbZVM0MEFq42//RopWU7cH2UwLxMxXof+7OYy/lh1qYsIFJLPyFN9ydNpyC4wBxH+hYULiG74E6Yk/e7KgGrVvref4qKd+90KfE44r9qk/6TSJgmZpI+TjwvuiazLNjlDdMpgDunLBCrAItfduXIXmqrfxqlZ7siahZoJSnYviJFUcG36l610VeXVFpH4OBOdFDnso+wriixeaDs4WErnKkNUBS2KLbrJ1Y1UKBTCx6nAT96QB0+AVLvAfKLu9U6aY8dwioXeV1dbgkASmo5hsTxE7ogX8jpIr+4jXqXc0wEjhSuQwzUmZAoZpT8FGpb/UhN6uWdauLAWN3obcNKVRWemlnuwf6vXpMNhfLGUG8THGCv4DSsm8O4sNaMsHmcFoOnjbVvmcOA6qT3lTeXqXSnCjZtteTrW1r8pq2QnP9A97ayP/kXeTqGSubCDT4PVt7bpQa3iRu5AkC/frGk4P+H6U6y+FK1M9rgK9QovWgHmJfaneQjYwl6mQQIvjBf2erA7JtTBeHOAKl/MEP0aci5IUlhAegI5PVr3wWIN1FuhWpjRAXuBJ6U6+nUVU1lCWFgB2vKGfescIK2GZY46fuhnbmSRED9gr4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:imwO2Qk3nMcw9tvqO+gHnAbONDkxfwekn20TMCtyI36tM2CPJ2Jp1hnSyFqjcedXkHhbSS6wwKChjd4zKvzEr2z80olMspTI7w8c+BbHUY9e7oIoiRhAse0EiBJjbfWqFSKmSW7yR4w/NeGDCYfNurm35B7lLPb3bTzDjFE+BqzGm96WCZqJpq1XwWDZlMgCCWfu96EGM+0uf0dg86BqY71ue3wWrZtXSFyHk5sPbc+fjPwlwmro6ubG7i5UZYCjphhQktoml5d5bkzL+r5IssaeW3T05t/NcXhrsUBBNyucJGpm+LQXTqWyfipRsQfPedwA9cwB6UGPz9d60Ad6LaSHgtHaHw9+E7R1ITp+cWRa2gMHdyWQ72G08WiZPZow X-Forefront-PRVS: 083691450C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(24454002)(377424004)(92566002)(77096005)(50466002)(3846002)(54356999)(5008740100001)(122386002)(1096002)(23726003)(4001350100001)(5001960100002)(47776003)(6116002)(66066001)(40100003)(1076002)(110136002)(5004730100002)(97756001)(586003)(86362001)(189998001)(50986999)(2950100001)(3470700001)(87976001)(42186005)(33656002)(19580405001)(76176999)(19580395003)(4326007)(46406003)(2906002)(61506002)(83506001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1713; 23:GqsWZME31k/88hMUgtwOQea2G7p4zmTi8D9PClb?= =?us-ascii?Q?YGCGXbvYI5Kb7qNbv5ko4/q7lC+BRIKu+VmC5i/zBVn2k9h99ZvJocjTvp4p?= =?us-ascii?Q?7Lb6OVsyzuTu5H5Nr+tR0/bJOMhCwdaVxxUnqlnd0zaFX1Cg0zcYFor3PiVA?= =?us-ascii?Q?QK/e6Iz2ZXQtb9nhiLvhTX2vwZGGQBbPaCU4W+kOXkG3NDSVAqyykz2JPDyG?= =?us-ascii?Q?AFVyV30nRBusGNoSTDJB0CFbWCZVCkgureBlyZSggZEbNbH4xpsUSQOAQsUM?= =?us-ascii?Q?SiA31HJVSSpPnKRa+dxrPkdaI1LWQsxI4I0rXSdw+3r0lZwsC4/yJm1sgHnF?= =?us-ascii?Q?PFBJzm+wkwtC9t9s+rwHI1zmxraPkWCTNS8Fn6pYWefCUmFRWR+OM5l4+ESK?= =?us-ascii?Q?JQBFGsRNeyuyVhFYO8yf4PNaXa/uZWljw36wPkfBrSuKP8JirDqC/j1exbED?= =?us-ascii?Q?Vfvuwt6ZTd1RVRqOI+4hsMDfEKjJbgexNLCBINk/8KvaK0YnsoWU8oVN8I1f?= =?us-ascii?Q?F6rMlEk+mxKZridbfLUby8ysddXHgyiBMwNw6MOXWECkyNZDJ3lneovPiz3d?= =?us-ascii?Q?i3UAGV16gD1Ey9ehANe+O0KaFObEnmp+Q+WB/WvF4XS43e8pZfPqorD0LXJZ?= =?us-ascii?Q?Q7gZw9LGocodQC/dRM92BHTZ5oly53aaViQi1DFBVYQC+UPQMV7KBdr8OD9d?= =?us-ascii?Q?/VIR9MGj58Q94k0O+OGDUvhIIdGrhD4hJ+vfBAamHdgQQERZjbMwx4D2ECYT?= =?us-ascii?Q?7gWeAHgZ5ImoTIUBwjX1hL902gJ//hdCD6akhLIKLIUqnr3X5Pf65D1Crg89?= =?us-ascii?Q?bBVnL8R4oXhuOVUDSxbaIcc2A4mKaHFlPV/g+K3Pr3DGGJPBfeTxa6a6XrOo?= =?us-ascii?Q?eZ50L13MwL7oZOkAtZCkzYHhzTU6p4Z6egxGfAvIoCMTToX/yZPTGGq4hEu4?= =?us-ascii?Q?GJOfy5RxGF8PAyGhH2Tm2JedigQNu3Rq7QTunaKSTEMdedrlG5VMM0/SR6Ed?= =?us-ascii?Q?hmo8geWeoq+HGhpE175JZN/DI07laUm4ziSickE3Iqrm5U81Cn2F47ekGjV8?= =?us-ascii?Q?9t/WrLdSaKTdecNOFsMmIpjLtaMWC/Il4rZ2e6qzaQDIdUiGDzw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 5:dw4tvBF9LJp/MW/ydng+5/hliVl5bPqvj7+Dyzuwmii7/cDOKZ07goBY+QK39ciqDEtax3UV6p3BY8+ZSFp4W6kUxOjoG55yXvPycH8kiobiEC8MOeQ02U7FsdSR2/2Chu+qFOimTk9LrbeUWn5OLA==; 24:cyb4AYo+FyPrgixyplk0tXbOapR/VVyrOXH4gybsVEHZROlDD/Q0BcPK4FRN/j3/XWH6+56fGEQZtKhXQmkJaQ1xG5bNlzA6mLhCH2uvqt4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2016 04:25:18.1849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 04:25:24 -0000 On Tue, Dec 08, 2015 at 03:03:34PM +0530, Jerin Jacob wrote: > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > 2015-12-07 19:52, Jerin Jacob: > > > by default, all the targets will be configured with the 64-byte cache line > > > size, targets which have different cache line size can be overridden > > > through target specific config file. > > > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > > based on existing configuration. > > > > > > Signed-off-by: Jerin Jacob > > > > It looks good. > > We are moving from a constant defined on CC command line in most cases > > to a constant included in rte_config.h only. > > Have you checked that the generated libraries are identical? > > Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte > (arm64-thunderx-linuxapp-gcc) target. > md5sum build/app/test comes same with or without patch. ping > > > It would be good to have a check for POWER8. Chao? > > Thanks