From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B0DB6377E for ; Mon, 1 Feb 2016 02:38:33 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 31 Jan 2016 17:38:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,378,1449561600"; d="scan'208";a="873637003" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga001.jf.intel.com with ESMTP; 31 Jan 2016 17:38:31 -0800 Date: Mon, 1 Feb 2016 09:39:48 +0800 From: Yuanhan Liu To: "Lu, Wenzhuo" Message-ID: <20160201013948.GZ4257@yliu-dev.sh.intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <533710CFB86FA344BFBF2D6802E6028622F260A3@SHSMSX101.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 01:38:34 -0000 On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote: > Hi, > > > -----Original Message----- > > From: Qiu, Michael > > Sent: Friday, January 29, 2016 3:16 PM > > To: Lu, Wenzhuo; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on > > Intel X550 NIC > > > > Hi, Wenzhuo > > > > Better to explain what E-tag is, so that reviewers could known it. > Yes, it's better. But not sure where should I add this info. In release note or just cover letter? Any suggestion? Thanks. It should be done in the first patch introduced E-tag, so that it will be in the git log history. And of course, it does no harm at all to mention (briefly) it again in cover letter, so that reviewer/maintainer has a brief understanding of your whole patchset first. --yliu