From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id BA29E56B7
 for <dev@dpdk.org>; Tue,  2 Feb 2016 08:02:07 +0100 (CET)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id u127226T014070;
 Mon, 1 Feb 2016 23:02:03 -0800
Date: Tue, 2 Feb 2016 12:32:01 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20160202070158.GA3459@scalar.blr.asicdesigners.com>
References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com>
 <1454076516-21591-5-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454076516-21591-5-git-send-email-david.marchand@6wind.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Cc: dev@dpdk.org, kumaras@chelsio.com, nirranjan@chelsio.com,
 viktorin@rehivetech.com
Subject: Re: [dpdk-dev] [PATCH 4/9] eal/linux: move back interrupt thread
 init before setting affinity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2016 07:02:08 -0000

Hi David,

On Friday, January 01/29/16, 2016 at 15:08:31 +0100, David Marchand wrote:
> Now that virtio pci driver is initialized in a constructor, we only need to
> move the interrupt thread init after loading the plugins.
> This way, chelsio driver should be happy again [1].
> 
> [1] http://dpdk.org/ml/archives/dev/2015-November/028289.html
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 635ec36..62241ee 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -823,6 +823,9 @@ rte_eal_init(int argc, char **argv)
>  	if (eal_plugins_init() < 0)
>  		rte_panic("Cannot init plugins\n");
>  
> +	if (rte_eal_intr_init() < 0)
> +		rte_panic("Cannot init interrupt-handling thread\n");
> +
>  	eal_thread_init_master(rte_config.master_lcore);
>  
>  	ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
> @@ -834,9 +837,6 @@ rte_eal_init(int argc, char **argv)
>  	if (rte_eal_dev_init() < 0)
>  		rte_panic("Cannot init pmd devices\n");
>  
> -	if (rte_eal_intr_init() < 0)
> -		rte_panic("Cannot init interrupt-handling thread\n");
> -
>  	RTE_LCORE_FOREACH_SLAVE(i) {
>  
>  		/*
> -- 
> 1.9.1
> 

Thank you for this patch.  I've tested it and it does improve the perf.
back when there is a queue on master lcore in l3fwd app.

Thanks,
Rahul