From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 7E5F295D1
 for <dev@dpdk.org>; Tue,  2 Feb 2016 03:20:43 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id w123so1314256pfb.0
 for <dev@dpdk.org>; Mon, 01 Feb 2016 18:20:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=3xn3NRgxMUO2qb0ofVffpWET53JAFm125yxW6P7T/9g=;
 b=03wvKBvjzxOvflxQm6RCjTrRJXZJd5Y17ycTHvfkmWdImCAnAqrbEs4mfaSuf+MK+D
 Ub6QZFnbSKTCi0zkc1YwTwDIlsGoLiFSNyXZLYejjOeumjE2wsoqxEIFQwVE2nGv/oWL
 coSjAaliqIBLf6aQMca2OQji6utzEiDuxqVMN8N5xe8datYBDCl5efJONBzF6vVDqr+z
 si7RzhaEal/kRJDG1HBVcNs02azdj/f1P15ZYHB06UorqOUyc6hDrZQC/9/cpPGAfuxn
 tDpOXrhFhW7rzGZ9rNRC25xKtAzPsGcV7OIceqm/KNtPBU5LHTgH4Hqwk/24hqHWwDeQ
 RcJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=3xn3NRgxMUO2qb0ofVffpWET53JAFm125yxW6P7T/9g=;
 b=h3MJWdwjIQyBDNVzUCwDx3k9Qj+uidNMEdKGlc5T0UVKTQawTUV9cwKqyDuBOPTwwp
 mwUHU2UzGKQJ5KzVww1assrZQEr/IShN0IwRJgSf4X3HwSNIUz848LW2XusWte9OLYr8
 K2PMykAP8ugKjcFilAtHpMXcFsbeWpna5urYc5DhbwTWW966EOBRew5m6i9sel/HofqS
 CNpv0DY0zbHdVkgUhjzESsFRy+FuTsoZLI2V5gf2qckWkJ1epMzeUSOTvjqzdAEZaPsy
 AGqnQxd4VASYxFTt7LkSIBNE+lZ9E/FZ1V1d3xu75oFBWr6Zsi1wJ04M0mVC4To3mj49
 Sm2Q==
X-Gm-Message-State: AG10YOQ+neyoHkZADJjafHcsILSkED01BRP5f6cB8uWDkZD8EmMSnA4X4US6ET9ofal5+g==
X-Received: by 10.98.9.92 with SMTP id e89mr12106224pfd.34.1454379642945;
 Mon, 01 Feb 2016 18:20:42 -0800 (PST)
Received: from samsung9 ([138.44.251.21])
 by smtp.gmail.com with ESMTPSA id o17sm13977567pfj.50.2016.02.01.18.20.41
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 01 Feb 2016 18:20:42 -0800 (PST)
Date: Tue, 2 Feb 2016 13:20:35 +1100
From: Stephen Hemminger <stephen@networkplumber.org>
To: Harish Patil <harish.patil@qlogic.com>
Message-ID: <20160202132035.3db9bc4b@samsung9>
In-Reply-To: <D2CF9056.12BC4A%harish.patil@qlogic.com>
References: <1440807373-24770-1-git-send-email-marc.sune@bisdn.de>
 <1443993167-1150-1-git-send-email-marcdevel@gmail.com>
 <1443993167-1150-4-git-send-email-marcdevel@gmail.com>
 <D2CF9056.12BC4A%harish.patil@qlogic.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 3/4] ethdev: redesign link speed config API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2016 02:20:44 -0000

On Thu, 28 Jan 2016 17:33:20 +0000
Harish Patil <harish.patil@qlogic.com> wrote:

> * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric
>   values of all supported link speeds, in Mbps.

I would prefer that there were no speed value macros.
Linux used to have these, but people kept adding new hardware speeds
and it soon gets out of date.

If you are going to redo it, then just increase speed to 64 bit, and allow
any non-zero value.