From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id 1EEA88E5D for ; Wed, 3 Feb 2016 00:51:53 +0100 (CET) Received: from jvn (dynamic-109-81-211-64.ipv4.broadband.iol.cz [109.81.211.64]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3pw2x429sWz8Jh; Wed, 3 Feb 2016 00:51:52 +0100 (CET) Date: Wed, 3 Feb 2016 00:51:51 +0100 From: Jan Viktorin To: Thomas Monjalon Message-ID: <20160203005151.74bfa595@jvn> In-Reply-To: <1454453993-3903-1-git-send-email-thomas.monjalon@6wind.com> References: <1454453993-3903-1-git-send-email-thomas.monjalon@6wind.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 0/5] clean-up cpuflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 23:51:53 -0000 Hello Thomas, the patch set fails when compiling for ARMv7 with the following (full build.log is attached): /var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/ar= ch/arm/rte_cpuflags.c:114:22: error: =E2=80=98REG_PLATFORM=E2=80=99 undecla= red here (not in a function) FEAT_DEF(V7L, REG_PLATFORM, 0) ^ /var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/ar= ch/arm/rte_cpuflags.c:71:26: note: in definition of macro =E2=80=98FEAT_DEF= =E2=80=99 [RTE_CPUFLAG_##name] =3D {reg, bit, #name}, ^ /var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/ar= ch/arm/rte_cpuflags.c: In function =E2=80=98rte_cpu_get_features=E2=80=99: /var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/ar= ch/arm/rte_cpuflags.c:144:8: error: array subscript is not an integer out[REG_PLATFORM] =3D 0x0001; ^ /var/lib/jenkins/jobs/dpdk-armv7-testing/workspace/lib/librte_eal/common/ar= ch/arm/rte_cpuflags.c:144:5: error: statement with no effect [-Werror=3Dunu= sed-value] out[REG_PLATFORM] =3D 0x0001; ^ =20 cc1: all warnings being treated as errors Regards Jan On Tue, 2 Feb 2016 23:59:48 +0100 Thomas Monjalon wrote: > Following the work of Ferruh, I suggest this cleanup to remove as much > as possible of the code from the cpuflags headers. > The goal is to un-inline these functions (not performance sensitive) > and remove the CPU flags table from the ABI (just added recently). > The bonus is to stop mimic x86 in ARM and PPC implementations. >=20 > WARNING: it has not been tested nor compiled on Tilera, ARM and POWER8. > Please help, thank you. >=20 > Thomas Monjalon (5): > eal: get CPU flag name > eal: move CPU flag functions out of headers > eal/arm: adapt CPU flags check to the arch > eal/ppc: adapt CPU flags check to the arch > eal: remove compiler optimization workaround >=20 > app/test/test_hash_scaling.c | 2 + > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 +- > lib/librte_eal/common/arch/arm/rte_cpuflags.c | 170 +++++++++++++++= +----- > lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 145 +++++++++++++--= --- > lib/librte_eal/common/arch/tile/rte_cpuflags.c | 11 ++ > lib/librte_eal/common/arch/x86/rte_cpuflags.c | 91 +++++++++++ > lib/librte_eal/common/eal_common_cpuflags.c | 18 +-- > .../common/include/arch/arm/rte_cpuflags_32.h | 78 ---------- > .../common/include/arch/arm/rte_cpuflags_64.h | 79 ---------- > .../common/include/arch/ppc_64/rte_cpuflags.h | 64 -------- > .../common/include/arch/tile/rte_cpuflags.h | 29 ---- > .../common/include/arch/x86/rte_cpuflags.h | 66 -------- > .../common/include/generic/rte_cpuflags.h | 56 ++----- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +- > 14 files changed, 364 insertions(+), 450 deletions(-) >=20 --=20 Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic