From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id B1C7B95C8 for ; Wed, 3 Feb 2016 04:36:31 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id 65so5764490pfd.2 for ; Tue, 02 Feb 2016 19:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=91hpqilwpT87Clx4eLZo9LZCkUM5RpxxZvQyVP6dPNQ=; b=jx1nObmwfahSQPDTaMZ8Ftn5IGjJzdouGE4i1bci0VHPJxEJJtxyVpoWyQspv6HfaS z39iIWZhIY2CLt+NY7fwnBoirIOs9luXZCwTzJr6KBP1bshtc+VUjV2VsrZhZvCt4qBk vmt9PgkMZXNjskxm8N8zFJeSFeySkaMUuuBRsIVfWjmaJkLuM1U/Oz1VGGQMVB3tN9Tw FPSNCSVFcBmuRJ1+Kd/R57BsQUlJ4YEve6Yb6IzTjlK59mq21HNgO0c3idm6xaHSx98W yi9eqSH7b12jpVBtCQU0nRftyA94mpsc8hiANkdyz7TPtcsuwIlju07RpT5jmy8+85Pr mLqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=91hpqilwpT87Clx4eLZo9LZCkUM5RpxxZvQyVP6dPNQ=; b=TKKJ2ecWP6VTZ/OzQscA8DukaFEl6mImFnvQO1HZYOaTHkUfB4ImmRgebNxMVsHChd m+j+mPAsd56PCxr0+fLvSn2R2xyi22WQV1Uc7k+2DMi5lX62bI8VYq7F/yvKBTQ9v0CK 0EcfzWpokTXgwCbEEnzDWg9jkIjFlQif0sXlordSRxGspFbINSRVV+6rr7FhjTVlbE2H LhyBWxG3R09URmO4nBoQIOzSptj3V03fMONLruo2bQ6zLExRMljepCJx+SSS/ldrjvpZ RTweHMDczwQ5oSWuzHSaSb5zYOpBvF1g8aLm2UyqaxxWn/2zz+dzKKvUxHbSXfbMrenA Fxuw== X-Gm-Message-State: AG10YOTcwU4xG/YCzmmuCqjoOuMhPQPtMjBxXljclVB/Z0ByBf8vsswwoy7+KDrvO7dJeQ== X-Received: by 10.98.18.8 with SMTP id a8mr52983386pfj.41.1454470591020; Tue, 02 Feb 2016 19:36:31 -0800 (PST) Received: from samsung9 ([138.44.251.21]) by smtp.gmail.com with ESMTPSA id n27sm5739696pfb.53.2016.02.02.19.36.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Feb 2016 19:36:30 -0800 (PST) Date: Wed, 3 Feb 2016 14:36:20 +1100 From: Stephen Hemminger To: Wenzhuo Lu Message-ID: <20160203143620.7eccc836@samsung9> In-Reply-To: <1454396225-11784-3-git-send-email-wenzhuo.lu@intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <1454396225-11784-1-git-send-email-wenzhuo.lu@intel.com> <1454396225-11784-3-git-send-email-wenzhuo.lu@intel.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/7] lib/librte_ether: support l2 tunnel config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 03:36:32 -0000 On Tue, 2 Feb 2016 14:57:00 +0800 Wenzhuo Lu wrote: > +/** > + * l2 tunnel configuration. > + */ > +struct rte_eth_l2_tunnel { > + enum rte_eth_l2_tunnel_type l2_tunnel_type; > + uint16_t ether_type; > +}; Building an API with an indirect (structure) parameter with only two elements seems like overkill. If you are building it to support future features, that won't work because it will break ABI. Why not just? int rte_eth_dev_etag_enable(uint8_t port_id, uint16_t ether_type)