From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5AE455A06
 for <dev@dpdk.org>; Wed,  3 Feb 2016 17:31:17 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 03 Feb 2016 08:31:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,391,1449561600"; d="scan'208";a="907754525"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159])
 by fmsmga002.fm.intel.com with SMTP; 03 Feb 2016 08:31:13 -0800
Received: by  (sSMTP sendmail emulation); Wed, 03 Feb 2016 16:31:13 +0025
Date: Wed, 3 Feb 2016 16:31:12 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Message-ID: <20160203163112.GA2528@bricha3-MOBL3>
References: <1450848779-8183-1-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450848779-8183-1-git-send-email-helin.zhang@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization
 failure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Feb 2016 16:31:17 -0000

On Wed, Dec 23, 2015 at 01:32:59PM +0800, Helin Zhang wrote:
> Workaround for the issue of cannot processing adminq commands during
> initialization, when 2x40G or 4x10G is receiving packets in highest
> throughput. Register 0x002698a8 and 0x002698ac should be cleared at
> first, and restored with the default values at the end. No more
> details, as they are not exposed registers.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

Hi Helin,

can you please add an appropriately "fixes" line to the patch, since the
subject explicitly calls it out as a bug-fix. Also, the words "the issue" in
the subject can be removed as they don't add value. It would also be worthwhile
referencing the adminq in the subject too, since that is the failure being
reported. How about:

	"i40e: fix adminq failure on port init"

Regards,
/Bruce