From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 753A5568F
 for <dev@dpdk.org>; Thu,  4 Feb 2016 10:52:58 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga102.jf.intel.com with ESMTP; 04 Feb 2016 01:52:57 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,395,1449561600"; d="scan'208";a="42257802"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159])
 by fmsmga004.fm.intel.com with SMTP; 04 Feb 2016 01:52:55 -0800
Received: by  (sSMTP sendmail emulation); Thu, 04 Feb 2016 09:52:54 +0025
Date: Thu, 4 Feb 2016 09:52:54 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Wang Xiao W <xiao.w.wang@intel.com>
Message-ID: <20160204095254.GA8868@bricha3-MOBL3>
References: <1450784205-10880-2-git-send-email-xiao.w.wang@intel.com>
 <1454574452-30741-1-git-send-email-xiao.w.wang@intel.com>
 <1454574452-30741-2-git-send-email-xiao.w.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454574452-30741-2-git-send-email-xiao.w.wang@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] testpmd: fix wrong prompt in tx_vlan set
 command handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2016 09:52:58 -0000

On Thu, Feb 04, 2016 at 04:27:32PM +0800, Wang Xiao W wrote:
> When using testpmd, sometimes we forget the right order of port_id and
> vid in "tx_vlan set (port_id) vlan_id[, vlan_id_outer]\n" command, and
> input "tx_vlan set 51 0", we'll get a strange prompt saying "Error, as
> QinQ has been enabled.".
> 
> In cmd_tx_vlan_set_parsed function, the first thing we do is checking
> the port's vlan_offload capability, rather than checking validity of the
> port_id, therefore if it's an invalid port_id we'll get the above wrong
> message. We should always make sure that we get a valid port_id before
> we do other things.
> 
> It's the similar issue for cmd_tx_vlan_set_qinq_parsed function.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>

Please include a fixes line, in patches fixing problems.
thanks,
/Bruce