From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D27CB95DB for ; Thu, 4 Feb 2016 14:37:45 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 04 Feb 2016 05:37:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,395,1449561600"; d="scan'208";a="740459817" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga003.jf.intel.com with ESMTP; 04 Feb 2016 05:37:19 -0800 Date: Thu, 4 Feb 2016 21:39:13 +0800 From: Yuanhan Liu To: Pavel Fedin Message-ID: <20160204133913.GD16802@yliu-dev.sh.intel.com> References: <00b201d15f36$e87e0260$b97a0720$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00b201d15f36$e87e0260$b97a0720$@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, 'Dyasly Sergey' Subject: Re: [dpdk-dev] PING: [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 13:37:46 -0000 CC Thomas. --yliu On Thu, Feb 04, 2016 at 01:29:19PM +0300, Pavel Fedin wrote: > Hello! Are there any news about this patch? We have got this problem for the second time, it reproduces every time we try to use > ovs-dpdk inside virtual machine with virtio-net adapter. > > Kind regards, > Pavel Fedin > Senior Engineer > Samsung Electronics Research center Russia > > > > -----Original Message----- > > From: Jianfeng Tan [mailto:jianfeng.tan@intel.com] > > Sent: Monday, January 11, 2016 9:16 AM > > To: dev@dpdk.org > > Cc: p.fedin@samsung.com; yuanhan.liu@linux.intel.com; Jianfeng Tan > > Subject: [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop > > > > v2 changes: > > - Address compiling error. > > - Add Reported-by. > > > > Fix the issue that virtio device cannot be started after stopped. > > > > The field, hw->started, should be changed by virtio_dev_start/stop instead > > of virtio_dev_close. > > > > Reported-by: Pavel Fedin > > Signed-off-by: Jianfeng Tan > > Acked-by: Yuanhan Liu > > > > --- > > drivers/net/virtio/virtio_ethdev.c | 14 +++++++++----- > > 1 file changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > > index d928339..5bdd305 100644 > > --- a/drivers/net/virtio/virtio_ethdev.c > > +++ b/drivers/net/virtio/virtio_ethdev.c > > @@ -490,11 +490,13 @@ virtio_dev_close(struct rte_eth_dev *dev) > > > > PMD_INIT_LOG(DEBUG, "virtio_dev_close"); > > > > + if (hw->started == 1) > > + virtio_dev_stop(dev); > > + > > /* reset the NIC */ > > if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) > > vtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR); > > vtpci_reset(hw); > > - hw->started = 0; > > virtio_dev_free_mbufs(dev); > > virtio_free_queues(dev); > > } > > @@ -1408,10 +1410,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev) > > if (rte_eal_process_type() == RTE_PROC_SECONDARY) > > return -EPERM; > > > > - if (hw->started == 1) { > > - virtio_dev_stop(eth_dev); > > - virtio_dev_close(eth_dev); > > - } > > + /* Close it anyway since there's no way to know if closed */ > > + virtio_dev_close(eth_dev); > > + > > pci_dev = eth_dev->pci_dev; > > > > eth_dev->dev_ops = NULL; > > @@ -1612,9 +1613,12 @@ static void > > virtio_dev_stop(struct rte_eth_dev *dev) > > { > > struct rte_eth_link link; > > + struct virtio_hw *hw = dev->data->dev_private; > > > > PMD_INIT_LOG(DEBUG, "stop"); > > > > + hw->started = 0; > > + > > if (dev->data->dev_conf.intr_conf.lsc) > > rte_intr_disable(&dev->pci_dev->intr_handle); > > > > -- > > 2.1.4 >