From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0098.outbound.protection.outlook.com [157.56.110.98]) by dpdk.org (Postfix) with ESMTP id D49FA377E for ; Mon, 8 Feb 2016 10:32:24 +0100 (CET) Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.167.181.96) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (TLS) id 15.1.396.15; Mon, 8 Feb 2016 09:32:19 +0000 Date: Mon, 8 Feb 2016 15:01:58 +0530 From: Jerin Jacob To: Message-ID: <20160208093157.GF10260@localhost.localdomain> References: <1450067576-18803-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454053555-28850-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1454053555-28850-1-git-send-email-jerin.jacob@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.181.96] X-ClientProxiedBy: BM1PR01CA0031.INDPRD01.PROD.OUTLOOK.COM (25.163.198.166) To BLUPR0701MB1714.namprd07.prod.outlook.com (25.163.85.140) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:7t4KlEwRXjKhrt5l+CawYKjy7V5Du91P55fLV9IygoLhS+EdYYO8bNxWrTih86BO3/tDl1QiEzf+Tw/RuO+yN8/3zC+nAhf+PJyWfqmSk2wBwqb9A/FhlvV+dtQi4UiqM5p22HiWPqFPPiTHNiSUuw==; 3:Vcp5HlrkyUmqu05mrX5tJpLWa/5893RGHDnoE9eeHoW4mkcm6aNbmgej81UXFFf9wtPU8yCbf6NK/yfVU6D6QVg3NRz5w/Dr0E16P9oKl/4kldVl+tPgqotxLxg84cVI; 25:W33KG607Lc+ZBNRQ0Priy85L80dvnYEnBxNhEdmqWv14kWT5C/xkqaU3XpiQcoaiZLQxf5szfR+UH3Pni/ySLXqRZHVp/pcCNKevp2n8P01LeM+fkO669wx8wNLxug+osHqE0JmJ16Ni9A8z/sf8t5BHI44OVElyd+fPia+bzxytMH707BKtFF0AGecqLvPblSJLRek6M2HIQjXK7OpJE54p6Y0WT4PnolLMdM+ar2mopKcjoz02s7kws1jRmLgDZIO+F2wq9PRO+l782ZnqpuTZerAGrnBbV8qst/bNz/txK3OddjzrPwyQFvMm2ooX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714; X-MS-Office365-Filtering-Correlation-Id: 7f29772d-ffdf-42b8-b6ec-08d3306abf62 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 20:WkY1aDyexQOpOWrWgqynl6giuzuI8vWgMwvMFf381PKpQ+1J09DzvKzL+AuEQJbs5O7eBAx30fFVxqRpRuzOlPp7dKYE7fvPbXsRLEbJ5v3EtVBF82S5lRQfnEhnniYIDyDymMH3v8RZLtbO1cx7Lia1BBDqMObZfgf3ufompkfv02c7Qzz6JzyuwV1HiIrxVUPLL6WiQJy83cRGM0XJipole7TXs2lXOeX3Bbnywo3iL4Y7FJqEJtUd+yosrYbls6/nRQQF3B1x0VCulxAUT8q+4kQOTsvRQFx2pvUlKVl81IjTqciY+lChBCoJcaPLlX3iZiDTj/PobISaJAgALVc+y+gvkTnUt+RYfFjKXd6rblVaTngjLf5CDEyyGSnPGxK6zSHamST6nVbXPLDy2NsUKuqENR0eKtJ5AwMNfC5SmYG24Vg2QGd/O5T3x7UKPIrRmBDnzI1hfrz/oW5rfPhDdrxYBCTKZuViGjo+SIDw0iksTK01bZ2RvHyUYbHzG19jhCHZr22EjqF5+iAyS4XHvutwtxmHmigQuzQMQpU6DMimU7iVFZM1dlO6LaP+dCW6QIeB5paDJwlsWqrQOPLN2UBpd4DeBirxt3sqMBY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:tgDf30G5LqUUQ0Uk8wcFzYp1zIu4O8IURiN25HOr3Amv3Sutla0WpQW9Lh2ZINa3xsi03aMCgW+p9LzpDNjKp7j1cC8tUSFdy6UbK/fXVZLw566oR8RwKXk0/qekdqT+GbgNMQgpkJRKL7w504hcH1ACn99Q0Jj6R4OZ/O0W220Jj4Cklu1OdJWH7TN3S8KuDHbqKjD54lOstStCUUiRCHC6nvuo5QEZ4pDPjqLeCVGrTIrugZrNYaqayeJTQkFfgs4JS9tSzoU8kmjgNuXGN/LmwnQyAoCH6F3YR9qpuulAL8jOBxZqYM5lXVv7dlqaxbSwkCFy53sGp+4hBL3Z0juIW7DR8ZxfTQbeDL4K9eIP/VCVNKIGt5C1yKqaYZsO X-Forefront-PRVS: 084674B2CF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(24454002)(46406003)(4326007)(19580405001)(586003)(87976001)(47776003)(5008740100001)(77096005)(2950100001)(19580395003)(83506001)(50466002)(5001960100002)(6116002)(110136002)(61506002)(3846002)(50986999)(76176999)(189998001)(42186005)(2906002)(5004730100002)(4001350100001)(1096002)(1076002)(122386002)(97756001)(2351001)(86362001)(23726003)(92566002)(33656002)(66066001)(54356999)(40100003)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:jATTS7SCg+fcCVJS0/U4y375iC4Jwr26PVbt+bh?= =?us-ascii?Q?o/1nUil9sdl7nvQV3neOdt5nDD/6AF8tHH41ukM8OIKpZaLfvBLfGZyagwXE?= =?us-ascii?Q?TH3J9hcrJqRT8jVJ0MJQp1pflYqYBYp88luhEpzqRypfnPzZkBmt5vorhEjM?= =?us-ascii?Q?zYqPpPZg9xU0GDHsp4OvrZ4TZgLJSj2fxeSaeBWZoufBLe/F7HR9I7DyLbOL?= =?us-ascii?Q?un/KtJYmD2Zs7itA6LJ1dyJ+UVI4ca8hA52Xj6ZPdR/0pA3vMBQ8PyoudLLQ?= =?us-ascii?Q?84cZ8sbBFt4Bb5ksRAwNOO4b9u3Mng2BuoRIEvOIPtmWIbUW8y3B/HpcrutS?= =?us-ascii?Q?g4Qx9f9T/hHO2BEh1bhOAPlzuTvyJc+OM+mtfI4/vBQ+fev113eT7wRCd+02?= =?us-ascii?Q?kgs9J6x23O9OjAqnWl8/hjlY/8ybycL8RCBS7nz9mg/m6IdIVf+CE8xDXUkK?= =?us-ascii?Q?I3HyhRayTzZ7TMJBHhJ/cbpR85eJbplziEXh0owz1YsC9QepSTqbb5QGEDWA?= =?us-ascii?Q?xY4eBMzX00X1fsrRo9c69WLMYsD5HPkZv+PIkJkC0wV8miXWYbNv1530Bg0b?= =?us-ascii?Q?Ybsf0v7ZrAL5Lfdth77c0m38drsIppEiYqkdf9d28lKU4HZhojqIH9YBVwvc?= =?us-ascii?Q?Q8HTOqSz66r213mOhdF6H+XrOqjpscnr92Ll3ET1Za6ruwZfVKfrCaiJSQxs?= =?us-ascii?Q?nJfc9+yxRzcmS+Qi+UoH64fZFyyUNuHcBXA2wwPzoJeKHWYX/pGkkRy+fR17?= =?us-ascii?Q?lcOygf343rKmTQrxJXiDxOWIhv7Dh0TVrZneMFzYI4KvC6qA7sQELKSc0q36?= =?us-ascii?Q?0NwU5ybJTsRv6JYg8c0PZ9CAAJVUHsEJy47csvvjVmuCPEIvngmji1HUpF9Q?= =?us-ascii?Q?JxYJMqfm+Wik8Rx5nVqjJdKICk3bDignpDlEx+gsWqTzgy7bsSeCDcO4G5Za?= =?us-ascii?Q?AQyadu1B6eIDE3BDkR3Q16xleiNKs9v2qX5kKTMQoH+9/LWGFkFFk0TgF9e0?= =?us-ascii?Q?NrbrG2HCawxYZcVV+lZsop0Vgu9PvE3jLI83OI8kgz8+SogISutGlA22Y0gL?= =?us-ascii?Q?IwsBKa2o=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 5:33xQE4hOL+dOOqwaMHE4n1MFwSMcZDxiUuQ8bYuJizLuLikwVgp8DzQQgOcvFMp8OnbUxu6KUy/0rMvqymn/Cs2EfovhVJMAEktT3sv2GHK0qMOAosP2rIn7ST4X+fugSjnhINI9lZpQ1iA3yQi4RA==; 24:GAMcrkFVb9Kp2FyHEyvowvUytj+33aStkJlf/og1Lr4n2IgSxgWJbe759jVsKWvAuYneRSgRkMOUcieCq2LW6qngZ2uD/c605SyiVkSPEGw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 09:32:19.6517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Cc: viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 09:32:25 -0000 On Fri, Jan 29, 2016 at 01:15:51PM +0530, Jerin Jacob wrote: > This patchset fixes performance/cache resource issues with 128-byte cache line targets > found in mbuf and bitmap DPDK libraries > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on > 128-bytes cache line size target. > > This patchset doesn't introduce any performance degradation > for 64-bytes cache line size targets. > > v1..v2 > - Introduced new cache macro definitions as Suggested by Konstantin > - Reduced the cache alignment requirement for 128-byte cache targets in > slow-path data structures to save the memory > - Verified x86(a 64byte cacheline target) does not have any impact on these changes by > verifying the md5sum of app/test,app/testpmd, app/testacl binaries with > or without this patch set > > v2..v3 > > revert the cache alignment of rte_ring_debug_stats, > rte_mempool_debug_stats structures > > v3..v4 > replaced RTE_CACHE_MIN_LINE_SIZE with RTE_CACHE_LINE_MIN_SIZE as suggested by > olivier.matz@6wind.com > > For clean git am, "config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme" > patch needs to apply first > > Jerin Jacob (4): > eal: Introduce new cache line macro definitions > mbuf: fix performance/cache resource issue with 128-byte cache line > targets > bitmap: optimize for 128-bytes cache line targets > cache/slow-path: reduce cache align requirement for 128-byte cache > targets > ping for review/merge > app/test/test_mbuf.c | 2 +- > lib/librte_eal/common/include/rte_memory.h | 16 ++++++++++++++++ > .../linuxapp/eal/include/exec-env/rte_kni_common.h | 4 +++- > lib/librte_ether/rte_ethdev.h | 4 ++-- > lib/librte_mbuf/rte_mbuf.h | 2 +- > lib/librte_sched/rte_bitmap.h | 10 +++++----- > 6 files changed, 28 insertions(+), 10 deletions(-) > > -- > 2.1.0 >