From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.Jacob@caviumnetworks.com> Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0093.outbound.protection.outlook.com [207.46.100.93]) by dpdk.org (Postfix) with ESMTP id CAF93559C for <dev@dpdk.org>; Mon, 8 Feb 2016 11:52:43 +0100 (CET) Authentication-Results: rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.167.179.57) by CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) with Microsoft SMTP Server (TLS) id 15.1.403.16; Mon, 8 Feb 2016 10:52:39 +0000 Date: Mon, 8 Feb 2016 16:22:17 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Jan Viktorin <viktorin@rehivetech.com> Message-ID: <20160208105216.GA14217@localhost.localdomain> References: <1450067576-18803-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454053555-28850-1-git-send-email-jerin.jacob@caviumnetworks.com> <20160208093157.GF10260@localhost.localdomain> <20160208112430.4cbc543a@jvn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160208112430.4cbc543a@jvn> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.179.57] X-ClientProxiedBy: BM1PR01CA0041.INDPRD01.PROD.OUTLOOK.COM (25.163.199.13) To CY1PR0701MB1728.namprd07.prod.outlook.com (25.163.21.142) X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 2:AoHgz9DudMOCsFhOspWbN6dBmFIi5ztz/MfHkt5e721fxxI3IaGy4H5AGbfkazejAG/VPwAo3bk/lycQopMBVUFE++3fLGMycQ9m0ofIfNh5Sg/GQu++YNQDrnSWmBmbx0f1jRzJZzrtMJoJ6OdYWg==; 3:3A7wS0x+ahZ2/31Mm/MII5VvFbYfHF/Y0yZiYb2wv6zwnBn1mShbAEYXe4/v2OYY9jr3tTZ7o1IhDTXOAUPXqbBILCT0XqRQ7ChLDpqsxYuyvZfVOt6Jp8Pd8PYY2E9A; 25:0jDFkVzb6f+cuDTr413LY4CtOFKcMfgSebGkrKebgi/CvVF8z6LeAN5hqVMYKMrBShA3zGCdWC/WdOTukOP6WuPNvr7GNed/hah2iAijLnYCWtCxWWJE5GS1dQ49tmYb4ERXDbIOQ+lD3d0uQwUopas5oc1gctQ0fTvGECG6B7a7eA8RwLtU2YxXdhIh9qz1d8v6OZ8SjUkuYtHhrZfYU4DGg4VFIZhdZepGwC8V9Ddm7kfDWToPU5yNOczwT/Ps8x9ZtbB9uSNKOqEcf7OwMkMHpSA0G4Cobl4FyBrtWj9h84O4Td9SQnOotBteF66c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1728; X-MS-Office365-Filtering-Correlation-Id: d236926d-95bb-4ca3-b5c0-08d33075f7e7 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 20:nLhadfu3lfLT+JHa/Km9A+xPpQkEkt7yahw5cgQJiJTEZY7QY4ib0MC1mpQPs1m+PP0g9Hk7JpNVGJkJFpI8ap8i4AEKSc/Q7qVcQOVbbroD++VgZp8UOXiXCEo7XvH9XIeiOMqxUpFFO5lq63o2x3UfBDF8wvhglfl/AQNEKTljdzA+I3CB5oQMp1feqmNZNi8LcRNTPFauIGpbvUZ9/MDcCvtQvukB7DBdc1f8S2SVgbLhZah5hqJUgDR6MUGd8ygj2F06VSGkuZf07DhpHCb07EEtYZNjgm715lslNBe5fsYKDWXfPAiWmVBP9U14/9oqqT2gAFvztVx0X4YpfDmKM7genuE3kmt1wOdebPTSdSDT47BkEqXHMCsAJSDyNLtB83Kwu6iDTgItR24aYMbd0uGYpLf5oKgKJ3MVc2YaJIrw3LUdKZt7BGSETRMNVss/JiyrNIhPjEl+4bqMQL8rPossnwTGaquZaR05e8SCbV1ojEtwezCn2Q3kHgc7CwjHf78e4Pv6y9523/7nAsi8AKUkEkZLz/2HLWG5BK5ckeWmgEXdXsX39MAvFDKFU+OPc0RZ4PONPsdRZJ8CJ5hJrkBTXYxdUCoTgoe9PRo= X-Microsoft-Antispam-PRVS: <CY1PR0701MB17283C2977764A7E7755BA3A8CD50@CY1PR0701MB1728.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:CY1PR0701MB1728; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 4:Q7/PdVw/nZUgoMolIyUW05zP4P/SQxtFLQtugqUVwUMTf9RVli1RKNb1w1lYvbhBwBVqME+B2QN4BnusE+7cLw6KCeCWNITpOd5TPTDCY/zfzqRTuRxMmBpRFdegapT1lnCDLpvW9esrql+pBDfgBfQ8xX1/QHQMXz8FATKeFRZ8j5IJ9KwSRMIS6X8ER1HquIXh22yF8XZM/W9A2ZyVKHe2aXdP09K/Hw48SDPOuG6dCw7gE8lwgCs9LifCk8Wqesfa+zrzujurrvEbkPtxxJFEGzFLkjmVvJ0bpKSke39O7ytGs5s5oZHxsi3nPwxqBMUHQkovsLuDRV+XcxM1n7fHmcRNFXMRq3oUR4IM4e82UUNsruzIGVTZ6zcUjkxt X-Forefront-PRVS: 084674B2CF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(50944005)(24454002)(252514010)(87976001)(33656002)(46406003)(83506001)(19580395003)(19580405001)(61506002)(122386002)(40100003)(92566002)(93886004)(15975445007)(77096005)(2950100001)(586003)(6116002)(3846002)(2906002)(1096002)(1076002)(5004730100002)(23726003)(189998001)(5008740100001)(4326007)(42186005)(50466002)(4001350100001)(15395725005)(97756001)(66066001)(86362001)(50986999)(54356999)(76176999)(47776003)(110136002)(5001960100002)(15974865002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1728; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1728; 23:K85HNWfQTWMkNLIQMYVdvZoECDEG2yrlS4XUv19?= =?us-ascii?Q?w+nunhzGnjDObjRyG5U7mqR58xExMB4BB/BY6I8nu6Sl0zmKbJrsnE/GTy7d?= =?us-ascii?Q?7Wzv0hOCyBkXmXBu1rbWg3gRamyhHVgeD2vB8dNawbveV9XvxLbHnPsXvMTC?= =?us-ascii?Q?4d2DsbHKKa8oafj68c9TqzjAGOsWMr4yrMGt6vpuzXtGqhRDQ4C/b78iYQAW?= =?us-ascii?Q?Y6rmC7KVLHxwB9+XH3yIMckQfwA+Zw0eOwkOCLrW3mxQLvmSkMXoNyDRacWe?= =?us-ascii?Q?AYV2add4knCpo5nyTzQYYfgJh/D1LJNEefkRoTAh/Xf/vpGd86ZpDHkEKXOA?= =?us-ascii?Q?jocd+v907NMenhIWOgbQyGhucKhk3etQsoReRJFwgnlFT3IAMNyNL0NTHI0K?= =?us-ascii?Q?9cDFnlCaPCCOe5CBG71w6cZburrTRR4qrYIqEPobnW//Fnk0zWetyLkLD/xR?= =?us-ascii?Q?Rt4e5UlrQbLocig+GaoFvOb8MJRvSj+VkEE3uLk73X7R+h/Yliilgb7mzHAn?= =?us-ascii?Q?dnSXoCh7jfe4EIQVv0Wrl3sdenliV8kGULXY/I12BoCkbuJ1cYMMD6igCMWS?= =?us-ascii?Q?NGnjRR9jOZ7wyCr/oJ70rbAXsURSYDPSesxWJlky+4meIpL3iVyRcij0bbfT?= =?us-ascii?Q?VSsEVXQrE0HSX+LC8o6UUfJms/Zn9fkQwDm7UrCucZ7ULwo42snmlDKqPz5u?= =?us-ascii?Q?a7IBnYA8SNe4bb8d4kBRTI1ciD2nG07/icNThy+2Q2sPylYmk1c2KPwiH5b5?= =?us-ascii?Q?m5VHKHqz3fwTuEWIx59wbwqc3u8BsQzL2UUgvKPt47UiqE7F0+l3tl3wUz6z?= =?us-ascii?Q?1HVRlJC41eg+jiL2JDxBSiddwqkpr6oCyMxSnjrm1MZgt8i+iRYnVHvoAkbt?= =?us-ascii?Q?ppf5xGWZ4N1GeDHVyTnt4J8163qUuGuAGHku9nxRgAU1ahttIcmzbCelTeZf?= =?us-ascii?Q?YZlwFZuzWEBkilfRYSb5sbK7xEbYzPyVP5mectTS1X7GITJW4LOuPk2ZetS2?= =?us-ascii?Q?g9/GFM9AShygFxptvBzJnn6m/QmoEH9p/yPU2SKze5JIreI6jJa0wvLo6Oa/?= =?us-ascii?Q?4ucHouq/bLUP9X5kidRaaOUG7O4xG0Qw8SQcvcNcA/lLHfbw0X2S5Rnv3Ho6?= =?us-ascii?Q?cxNOQvrzmPI/NasEj7fwUgNebn6YYhdCRk/8VRyVn7sj7hpNwUEovNir1jMg?= =?us-ascii?Q?zUpK0oZ09PkjTkw4=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 5:qgSdg0L2TYV0sQ4xguvIVZk1y/O5dCZlifQF0L4nJwBJgr9wEGjlXnbgImJtmYOrxQ6QRvJz+LExJRjd1Fc/xzTPWXOJuCFekI4GFg3G7HEWt35i3GYWJsechaWr4MDzAqmHexUaHMtJ9Ai4ot3Dww==; 24:+rCekb+yUbEaSGUkzw8/D5iLvKlCQjfyUqrNK+YkeVKD3yEbXIAgiH6CbU2hOEEyF29OA5AiCI1Q5h8MSk2zaJ6XWPpr7TcuZqptXTMEV6c= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 10:52:39.4867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 08 Feb 2016 10:52:44 -0000 On Mon, Feb 08, 2016 at 11:24:30AM +0100, Jan Viktorin wrote: > Hello Jerin, > > I failed to apply the v4 series. I've tried multiple bases. The v3 > applied successfully to v2.2.0-rc4. Could you give the proper working > base? Hello Jan, Please apply the depended "config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme" patch first as mentioned in the cover letter. http://dpdk.org/dev/patchwork/patch/9388/ > > Applying patch #10232 using 'git am' > Description: [dpdk-dev,v4,2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets > Applying: mbuf: fix performance/cache resource issue with 128-byte cache line targets > error: patch failed: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:68 > error: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h: patch does not apply > Patch failed at 0001 mbuf: fix performance/cache resource issue with 128-byte cache line targets > The copy of the patch that failed is found in: /home/jviki/upstream/dpdk/.git/worktrees/dpdk-pw/rebase-apply/patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > 'git am' failed with exit status 128 > Try to fix git-am manually or exit... > > Regards > Jan > > On Mon, 8 Feb 2016 15:01:58 +0530 > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > On Fri, Jan 29, 2016 at 01:15:51PM +0530, Jerin Jacob wrote: > > > This patchset fixes performance/cache resource issues with 128-byte cache line targets > > > found in mbuf and bitmap DPDK libraries > > > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on > > > 128-bytes cache line size target. > > > > > > This patchset doesn't introduce any performance degradation > > > for 64-bytes cache line size targets. > > > > > > v1..v2 > > > - Introduced new cache macro definitions as Suggested by Konstantin > > > - Reduced the cache alignment requirement for 128-byte cache targets in > > > slow-path data structures to save the memory > > > - Verified x86(a 64byte cacheline target) does not have any impact on these changes by > > > verifying the md5sum of app/test,app/testpmd, app/testacl binaries with > > > or without this patch set > > > > > > v2..v3 > > > > > > revert the cache alignment of rte_ring_debug_stats, > > > rte_mempool_debug_stats structures > > > > > > v3..v4 > > > replaced RTE_CACHE_MIN_LINE_SIZE with RTE_CACHE_LINE_MIN_SIZE as suggested by > > > olivier.matz@6wind.com > > > > > > For clean git am, "config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme" > > > patch needs to apply first > > > > > > Jerin Jacob (4): > > > eal: Introduce new cache line macro definitions > > > mbuf: fix performance/cache resource issue with 128-byte cache line > > > targets > > > bitmap: optimize for 128-bytes cache line targets > > > cache/slow-path: reduce cache align requirement for 128-byte cache > > > targets > > > > > > > ping for review/merge > > > > > app/test/test_mbuf.c | 2 +- > > > lib/librte_eal/common/include/rte_memory.h | 16 ++++++++++++++++ > > > .../linuxapp/eal/include/exec-env/rte_kni_common.h | 4 +++- > > > lib/librte_ether/rte_ethdev.h | 4 ++-- > > > lib/librte_mbuf/rte_mbuf.h | 2 +- > > > lib/librte_sched/rte_bitmap.h | 10 +++++----- > > > 6 files changed, 28 insertions(+), 10 deletions(-) > > > > > > -- > > > 2.1.0 > > > > > > > -- > Jan Viktorin E-mail: Viktorin@RehiveTech.com > System Architect Web: www.RehiveTech.com > RehiveTech > Brno, Czech Republic