From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 576FA559C for ; Mon, 8 Feb 2016 15:02:09 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 08 Feb 2016 06:02:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,416,1449561600"; d="scan'208";a="898626241" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159]) by fmsmga001.fm.intel.com with SMTP; 08 Feb 2016 06:02:07 -0800 Received: by (sSMTP sendmail emulation); Mon, 08 Feb 2016 14:02:05 +0025 Date: Mon, 8 Feb 2016 14:02:05 +0000 From: Bruce Richardson To: Wenzhuo Lu Message-ID: <20160208140205.GA22364@bricha3-MOBL3> References: <1451894836-27569-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451894836-27569-1-git-send-email-wenzhuo.lu@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: support multicast promiscuous mode on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 14:02:09 -0000 On Mon, Jan 04, 2016 at 04:07:16PM +0800, Wenzhuo Lu wrote: > Add multicast promiscuous mode support on ixgbe VF driver. > > Please note if we want to use this promiscuous mode, we need both PF > and VF driver to support it. The reason is this VF feature is > configged on PF. > If use kernel PF driver + dpdk VF driver, make sure kernel PF driver > support VF multicast promiscuous mode. If use dpdk PF + dpdk VF, > better make sure PF driver is the same version as VF. > > Signed-off-by: Wenzhuo Lu > --- Hi Wenzhuo, thanks for the patch. Is there a documentation update needed for this? The commit message in particular looks like it would be better in the official user documentation rather than just in the git history. Regards, /Bruce