[dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

[dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

[Stephen Hemminger]

The mbuf_alloc_size is leftover from BSD or some other code base.
It is set but never used in DPDK driver.  After that the related defines
can also be eliminated.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/bnx2x.c |  9 ---------
 drivers/net/bnx2x/bnx2x.h | 18 ------------------
 2 files changed, 27 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 67af5da..6ba6f44 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -2331,15 +2331,6 @@ static void bnx2x_set_fp_rx_buf_size(struct bnx2x_softc *sc)
 		/* get the Rx buffer size for RX frames */
 		sc->fp[i].rx_buf_size =
 		    (IP_HEADER_ALIGNMENT_PADDING + ETH_OVERHEAD + sc->mtu);
-
-		/* get the mbuf allocation size for RX frames */
-		if (sc->fp[i].rx_buf_size <= MCLBYTES) {
-			sc->fp[i].mbuf_alloc_size = MCLBYTES;
-		} else if (sc->fp[i].rx_buf_size <= BNX2X_PAGE_SIZE) {
-			sc->fp[i].mbuf_alloc_size = PAGE_SIZE;
-		} else {
-			sc->fp[i].mbuf_alloc_size = MJUM9BYTES;
-		}
 	}
 }
 
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 2abab0c..9682b8d 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -151,23 +151,6 @@ struct bnx2x_device_type {
 #define FW_PREFETCH_CNT      16U
 #define DROPLESS_FC_HEADROOM 100
 
-#ifndef MCLSHIFT
-#define MCLSHIFT                              11
-#endif
-#define MCLBYTES                              (1 << MCLSHIFT)
-
-#if !defined(MJUMPAGESIZE)
-#if BNX2X_PAGE_SIZE < 2048
-#define MJUMPAGESIZE    MCLBYTES
-#elif BNX2X_PAGE_SIZE <= 8192
-#define MJUMPAGESIZE    BNX2X_PAGE_SIZE
-#else
-#define MJUMPAGESIZE    (8 * 1024)
-#endif
-#endif
-#define MJUM9BYTES      (9 * 1024)
-#define MJUM16BYTES     (16 * 1024)
-
 /*
  * Transmit Buffer Descriptor (tx_bd) definitions*
  */
@@ -402,7 +385,6 @@ struct bnx2x_fastpath {
 	uint8_t fw_sb_id;  /* status block number in FW */
 
 	uint32_t rx_buf_size;
-	int mbuf_alloc_size;
 
 	int state;
 #define BNX2X_FP_STATE_CLOSED  0x01
-- 
2.1.4

Re: [dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

[Harish Patil]

>
>The mbuf_alloc_size is leftover from BSD or some other code base.
>It is set but never used in DPDK driver.  After that the related defines
>can also be eliminated.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
> drivers/net/bnx2x/bnx2x.c |  9 ---------
> drivers/net/bnx2x/bnx2x.h | 18 ------------------
> 2 files changed, 27 deletions(-)
>
>diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
>index 67af5da..6ba6f44 100644
>--- a/drivers/net/bnx2x/bnx2x.c
>+++ b/drivers/net/bnx2x/bnx2x.c
>@@ -2331,15 +2331,6 @@ static void bnx2x_set_fp_rx_buf_size(struct
>bnx2x_softc *sc)
>               /* get the Rx buffer size for RX frames */
>               sc->fp[i].rx_buf_size =
>                   (IP_HEADER_ALIGNMENT_PADDING + ETH_OVERHEAD + sc->mtu);
>-
>-              /* get the mbuf allocation size for RX frames */
>-              if (sc->fp[i].rx_buf_size <= MCLBYTES) {
>-                      sc->fp[i].mbuf_alloc_size = MCLBYTES;
>-              } else if (sc->fp[i].rx_buf_size <= BNX2X_PAGE_SIZE) {
>-                      sc->fp[i].mbuf_alloc_size = PAGE_SIZE;
>-              } else {
>-                      sc->fp[i].mbuf_alloc_size = MJUM9BYTES;
>-              }
>       }
> }
>
>diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
>index 2abab0c..9682b8d 100644
>--- a/drivers/net/bnx2x/bnx2x.h
>+++ b/drivers/net/bnx2x/bnx2x.h
>@@ -151,23 +151,6 @@ struct bnx2x_device_type {
> #define FW_PREFETCH_CNT      16U
> #define DROPLESS_FC_HEADROOM 100
>
>-#ifndef MCLSHIFT
>-#define MCLSHIFT                              11
>-#endif
>-#define MCLBYTES                              (1 << MCLSHIFT)
>-
>-#if !defined(MJUMPAGESIZE)
>-#if BNX2X_PAGE_SIZE < 2048
>-#define MJUMPAGESIZE    MCLBYTES
>-#elif BNX2X_PAGE_SIZE <= 8192
>-#define MJUMPAGESIZE    BNX2X_PAGE_SIZE
>-#else
>-#define MJUMPAGESIZE    (8 * 1024)
>-#endif
>-#endif
>-#define MJUM9BYTES      (9 * 1024)
>-#define MJUM16BYTES     (16 * 1024)
>-
> /*
>  * Transmit Buffer Descriptor (tx_bd) definitions*
>  */
>@@ -402,7 +385,6 @@ struct bnx2x_fastpath {
>       uint8_t fw_sb_id;  /* status block number in FW */
>
>       uint32_t rx_buf_size;
>-      int mbuf_alloc_size;
>
>       int state;
> #define BNX2X_FP_STATE_CLOSED  0x01
>--
>2.1.4
>
>

Acked-by: Harish Patil <harish.patil@qlogic.com>


Thanks,
Harish


________________________________

This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

[Bruce Richardson]

On Tue, Jan 05, 2016 at 04:53:28PM +0000, Harish Patil wrote:
> >
> >The mbuf_alloc_size is leftover from BSD or some other code base.
> >It is set but never used in DPDK driver.  After that the related defines
> >can also be eliminated.
> >
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >---
> 
> Acked-by: Harish Patil <harish.patil@qlogic.com>

Applied to dpdk-next-net/rel_16_04

/Bruce