From: Bruce Richardson <bruce.richardson@intel.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>
Cc: dev@dpdk.org, sony.chacko@qlogic.com
Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()
Date: Mon, 8 Feb 2016 16:03:25 +0000 [thread overview]
Message-ID: <20160208160325.GD22364@bricha3-MOBL3> (raw)
In-Reply-To: <56B8BA0A.9050100@brocade.com>
On Mon, Feb 08, 2016 at 07:53:46AM -0800, Charles (Chas) Williams wrote:
> I am afraid I don't understand what you are asking. This was broken in the
> commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be
>
Perfect. Generally, when adding a patch which fixes something, we add in a
"fixes line" into the comment. In this case it would be:
Fixes: 540a211084a7 ("bnx2x: driver core")
See also: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
/Bruce
> On 02/08/2016 05:51 AM, Bruce Richardson wrote:
> >On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote:
> >>From: "Charles (Chas) Williams" <ciwillia@brocade.com>
> >>
> >>bnx2x_loop_obtain_resources() returns a struct containing the status and
> >>the error message. If bnx2x_do_req4pf() fails, it shouldn't return both
> >>of these fields set to 0 indicating failure and no error.
> >>
> >>Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
> >>so that bnx2x_loop_obtain_resources() can negotiate reduced resource
> >>requirments. This requires additional checking around bnx2x_do_req4pf().
> >>
> >>Signed-off-by: Chas Williams <3chas3@gmail.com>
> >>---
> >
> >Hi Chas,
> >
> >can you please provide a commit reference for a fixes line for this patch. [No
> >need for a V2 just for that alone, just the reference is enough to save me
> >diving into the git history. I'll manually add the fixes line when committing
> >to the next-net tree]
> >
> >Maintainers, can you please review this patchset and provide feedback or an ACK.
> >
> >Regards,
> >/Bruce
> >
next prev parent reply other threads:[~2016-02-08 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 0:37 Chas Williams
2015-12-31 0:37 ` [dpdk-dev] [PATCH 2/2] bnx2x: Determine rx/tx queue sizes sooner Chas Williams
2016-03-04 22:28 ` Rasesh Mody
2016-03-10 10:32 ` Bruce Richardson
2016-02-08 13:51 ` [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources() Bruce Richardson
2016-02-08 15:53 ` Charles (Chas) Williams
2016-02-08 16:03 ` Bruce Richardson [this message]
2016-03-04 22:28 ` Rasesh Mody
2016-03-10 10:33 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208160325.GD22364@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).