From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2C02D2E83 for ; Mon, 8 Feb 2016 17:03:32 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 08 Feb 2016 08:03:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,416,1449561600"; d="scan'208";a="910906661" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159]) by fmsmga002.fm.intel.com with SMTP; 08 Feb 2016 08:03:26 -0800 Received: by (sSMTP sendmail emulation); Mon, 08 Feb 2016 16:03:25 +0025 Date: Mon, 8 Feb 2016 16:03:25 +0000 From: Bruce Richardson To: "Charles (Chas) Williams" Message-ID: <20160208160325.GD22364@bricha3-MOBL3> References: <1451522271-16924-1-git-send-email-3chas3@gmail.com> <20160208135101.GA13952@bricha3-MOBL3> <56B8BA0A.9050100@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B8BA0A.9050100@brocade.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, sony.chacko@qlogic.com Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 16:03:33 -0000 On Mon, Feb 08, 2016 at 07:53:46AM -0800, Charles (Chas) Williams wrote: > I am afraid I don't understand what you are asking. This was broken in the > commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be > Perfect. Generally, when adding a patch which fixes something, we add in a "fixes line" into the comment. In this case it would be: Fixes: 540a211084a7 ("bnx2x: driver core") See also: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body /Bruce > On 02/08/2016 05:51 AM, Bruce Richardson wrote: > >On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: > >>From: "Charles (Chas) Williams" > >> > >>bnx2x_loop_obtain_resources() returns a struct containing the status and > >>the error message. If bnx2x_do_req4pf() fails, it shouldn't return both > >>of these fields set to 0 indicating failure and no error. > >> > >>Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES > >>so that bnx2x_loop_obtain_resources() can negotiate reduced resource > >>requirments. This requires additional checking around bnx2x_do_req4pf(). > >> > >>Signed-off-by: Chas Williams <3chas3@gmail.com> > >>--- > > > >Hi Chas, > > > >can you please provide a commit reference for a fixes line for this patch. [No > >need for a V2 just for that alone, just the reference is enough to save me > >diving into the git history. I'll manually add the fixes line when committing > >to the next-net tree] > > > >Maintainers, can you please review this patchset and provide feedback or an ACK. > > > >Regards, > >/Bruce > >