From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 937AA9A88
 for <dev@dpdk.org>; Tue,  9 Feb 2016 09:39:43 +0100 (CET)
Received: by mail-wm0-f47.google.com with SMTP id g62so164596723wme.0
 for <dev@dpdk.org>; Tue, 09 Feb 2016 00:39:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:mail-followup-to:references
 :mime-version:content-type:content-disposition:in-reply-to;
 bh=h5gOKbMuRZcVcS0+JzM+f9EKXcgpH89rzVvn2hnzn8o=;
 b=CKG/pqThTvg53X+yIMXlSh965UGzs2znvM3sA3xpljRN31x7uh4nCfeIG0+xakP5fL
 4M2t2KsKlsDIDUC9uZGW3tr0x9eO7mTTTW13BwGqQdHgnuhqGZmIkYGzXoDXgFzzvFq/
 h4ksD0L+bTdmGvxyMJnP6aN2FvKxhC9rHGjHZvAua1CaOsxbPLAKkq4iRJVr7maXxFRU
 yDD+B1gvxgkcnZo0p6Ec04vnAdJDG3Mq0uTxzbGr2SlPZ/0qalf5bCikgpNAeiYhnyWr
 LZth6Ikw4afBKlcML1W70e0tmUrP4SqgXOSkQUhGiuzmBXEl40dqxlxqURLBtZ8wwzmu
 pPzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id
 :mail-followup-to:references:mime-version:content-type
 :content-disposition:in-reply-to;
 bh=h5gOKbMuRZcVcS0+JzM+f9EKXcgpH89rzVvn2hnzn8o=;
 b=k5zSAvFicSTLvwdLJJjgzCbgmxJhcPJcwxU4f7KZg8lPyjqTKRvV3XzrTSyIjis5Ri
 rPE8J8sJ5tK7Km/64yQ5sOYqYMFEwfkh4ozmf73bocKuUKj+QQUGi+5PV0RpnqsJasM4
 8ynn8YyqWdhAcb76XPkCLM+kXQaEp2wxJ+g8AAWZQUWw1idpXs2mJucyLfKe7b5fmxyJ
 3oemB0AngDj7xe94q46q55dU4gCGZ804d6YF+NoSArUJwP0AbPWOseGrc2WDTZR6oooB
 wjfOwWMRLoxMHis7fJaf7Y0hU0I9cM402J/mEOYCCvJHlxJR4flrOgDnCAqE99szXhzl
 iZwg==
X-Gm-Message-State: AG10YOTlIYC3p0FGgpHaHHCSCmUw2LTPpb2pbtZYQ8DaFvGTwHvU+fs+Iw8dJ4EB8zwi7Zdg
X-Received: by 10.194.115.164 with SMTP id jp4mr32876421wjb.26.1455007183471; 
 Tue, 09 Feb 2016 00:39:43 -0800 (PST)
Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id kb5sm33657497wjc.22.2016.02.09.00.39.42
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 09 Feb 2016 00:39:42 -0800 (PST)
Date: Tue, 9 Feb 2016 09:39:26 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20160209083926.GS27079@6wind.com>
Mail-Followup-To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
References: <1454969509-19157-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454969509-19157-1-git-send-email-bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mlx4: fix unneeded function error with clang
	v3.6
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Feb 2016 08:39:43 -0000

On Mon, Feb 08, 2016 at 10:11:49PM +0000, Bruce Richardson wrote:
> When compiling with clang 3.6, the mlx4 driver gives the following error
> message about an unneeded function.
> 
>   CC mlx4.o
> .../drivers/net/mlx4/mlx4.c:136:20: fatal error: function
>       'wr_id_t_check' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static inline void wr_id_t_check(void)
>                    ^
> 1 error generated.
> 
> The function is to compile-time check the size of wr_id_t, so use
> the standard DPDK BUILD_BUG_ON macro to do so in the init function
> instead.
> 
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND