* [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT
@ 2015-12-23 8:08 Rich Lane
2015-12-23 8:42 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Rich Lane @ 2015-12-23 8:08 UTC (permalink / raw)
To: dev
The no-refcount path was being taken without the application opting in to it.
Reported-by: Mike Stolarchuk <mike.stolarchuk@bigswitch.com>
Signed-off-by: Rich Lane <rlane@bigswitch.com>
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 39d94ec..d0bdeb9 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1762,7 +1762,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
for (i = 0; i < txq->tx_rs_thresh; i++)
rte_prefetch0((txep + i)->mbuf);
- if (!(txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT)) {
+ if (txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT) {
for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {
rte_mempool_put(txep->mbuf->pool, txep->mbuf);
txep->mbuf = NULL;
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT
2015-12-23 8:08 [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT Rich Lane
@ 2015-12-23 8:42 ` Zhang, Helin
2016-02-10 16:04 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2015-12-23 8:42 UTC (permalink / raw)
To: Rich Lane, dev
> -----Original Message-----
> From: Rich Lane [mailto:rich.lane@bigswitch.com]
> Sent: Wednesday, December 23, 2015 4:08 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin
> Subject: [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT
>
> The no-refcount path was being taken without the application opting in to it.
>
> Reported-by: Mike Stolarchuk <mike.stolarchuk@bigswitch.com>
> Signed-off-by: Rich Lane <rlane@bigswitch.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
Thanks for the good catch!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT
2015-12-23 8:42 ` Zhang, Helin
@ 2016-02-10 16:04 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-02-10 16:04 UTC (permalink / raw)
To: Zhang, Helin; +Cc: dev
On Wed, Dec 23, 2015 at 08:42:26AM +0000, Zhang, Helin wrote:
>
>
> > -----Original Message-----
> > From: Rich Lane [mailto:rich.lane@bigswitch.com]
> > Sent: Wednesday, December 23, 2015 4:08 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin
> > Subject: [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT
> >
> > The no-refcount path was being taken without the application opting in to it.
> >
> > Reported-by: Mike Stolarchuk <mike.stolarchuk@bigswitch.com>
> > Signed-off-by: Rich Lane <rlane@bigswitch.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
>
> Thanks for the good catch!
Applied to dpdk-next-net/rel_16_04
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-10 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 8:08 [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT Rich Lane
2015-12-23 8:42 ` Zhang, Helin
2016-02-10 16:04 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).