From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 9FE0595CA
 for <dev@dpdk.org>; Thu, 11 Feb 2016 02:12:23 +0100 (CET)
Received: by mail-pa0-f48.google.com with SMTP id fl4so8593986pad.0
 for <dev@dpdk.org>; Wed, 10 Feb 2016 17:12:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=lx7Im8P7BZyrEjxcZgJBegitm5EPCaifDFgl6bc/k8Q=;
 b=lVpY1TMNb+dq/OTjG/LXWlzAmfx4Shg1DuvWnPvg1iB9KspIgM4llr0/1N5NhMP8fD
 Rsc4b6soPw7oWwBPYa7e1foJKBW8BITSpk3RFY5x8OSuDvrDLJnSzKfoWASeWVjIxbkV
 9oKZz6JYeCRHHfVtEINlJRMmrbG1jCGBQhQu7IJxefYL6Gpe3aQOaIispEGSTwGTu7Yy
 Z5sAVgwcznMdaS0608e4NqgJDry7ZNNhfJYTKMZuxA2mp3FqNmuxyLA8AcG+vwllZpx2
 xTX3mquikucXlGVcKJPNOE3t5N0D+YHLmwMU8bU+EuGlmgZhvW8VgEGVuuoQ8hXmoMnS
 RtQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=lx7Im8P7BZyrEjxcZgJBegitm5EPCaifDFgl6bc/k8Q=;
 b=BibqPUgpbreqhaCglt2hnews1Er6N8X0t6TMdqBB1mx8XVJxouq2Q1Ujf0E3usd3/C
 pK8cZMDyiQ/gXpLlEXXaa8r6YRejL7GzXmHHw0mBNF4MfOKW10rNRjLeHWVKlgPOPSyH
 3tLx1eJ/3b2emMcwUX1Y3nuwszo87vDMSCHxNclvcGUwjihAuB+KC7Nq702rejkqpKRo
 NAjF0yfvu/N/cdYWQ0yCOh99LRUErxHbaZGgL/yG5wDfycY3uKxHcifxA8F0HUzrZmEY
 jyaqYVeSpTHBkn2SHSbimv4ZPtNb2EBjDLLCv+PUIVupaRAahgzYqkVZ4ThF93uyLvGx
 ekUA==
X-Gm-Message-State: AG10YOQWtyRvnCKPTFMfbJOXTPnW6sAzPR4W11dJRWvTYuxstNxdvJm67RwLs7FfZOuumQ==
X-Received: by 10.66.139.134 with SMTP id qy6mr62639078pab.45.1455153142984;
 Wed, 10 Feb 2016 17:12:22 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id o73sm7828964pfa.37.2016.02.10.17.12.22
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 10 Feb 2016 17:12:22 -0800 (PST)
Date: Wed, 10 Feb 2016 17:12:36 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent JARDIN <vincent.jardin@6wind.com>
Message-ID: <20160210171236.77aa24dc@xeon-e3>
In-Reply-To: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
References: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: prettify log messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Feb 2016 01:12:24 -0000

On Thu, 11 Feb 2016 00:45:34 +0100
Vincent JARDIN <vincent.jardin@6wind.com> wrote:

> PMD_TX_LOG() looks better with a \n
> 
> Signed-off-by: Vincent JARDIN <vincent.jardin@6wind.com>

NAK. Yes the messages, are messed up, but this is not
the right way to fix it.

The logging wrappers are inconsistent in virtio.
PMD_INIT_LOG adds newline, but RX/TX/DRV do not.

I would rather the macros were aligned with ixgbe which always
adds newline for all the PMD_XXX_LOG() macros. And then remove
all extra newlines in virtio code.