From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0057.outbound.protection.outlook.com [207.46.100.57]) by dpdk.org (Postfix) with ESMTP id 8E49837B2 for ; Fri, 12 Feb 2016 07:47:50 +0100 (CET) Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.172.185.217) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.409.15; Fri, 12 Feb 2016 06:47:44 +0000 Date: Fri, 12 Feb 2016 12:17:20 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20160212064719.GA3772@localhost.localdomain> References: <1449242086-19051-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com> <8996069.HySAWEmhf4@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8996069.HySAWEmhf4@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.172.185.217] X-ClientProxiedBy: PN1PR01CA0021.INDPRD01.PROD.OUTLOOK.COM (25.164.137.28) To BLUPR0701MB1716.namprd07.prod.outlook.com (25.163.85.142) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:PuqquS/mlJ8yqAu55M0RWddHQ/FDoEPbsxYLFCvHCmx2xlIPdD4JyC8BEOBG0RWV6WzrZosseRQvZ1fBb3EQAu16xdBJmYbCcdkJzIcNLJXuaLv3pCS0/mWt3B1EeKtJ45/phANd4RowbnjtI5LbtQ==; 3:tfFNWl76J1nObavsRVHMk7KGx60N0QAesmCuTQZyg/bREe9QKIcmXQgU7nhzKXGk/GNYmxNDxYnb56yfjyA3dqXpDsIKeAjK+l9kNb0JvDNy/8PLthBlUcLiB8TKDDpS; 25:HLbd4vcVxJd3MzoRB5rrrQpWK6AztzbzQ4lNErhmWicYvO716hoB0Z6ezwQb3jitoR7LPDl+lDG1mzVSxDfbrKiAJvPy97NJSSpBGyTE5NUemNNBb7J14TNNjilnCyCsXboTLXs5NAOKWXXxeoIYhRFy6hWmuiH+eiZz6z2Gzs9yVkF+Hh4UOHwijOfBlrZ5GVwTDlpYu19vL1MZCkC8W0K36CREFyvkUL3d2fTq94m/ukGFU21VavMTEK9Ikxn4/3cGT98EdldcGFAWBHYftTNyHVBGR8ThXIsJDmlYju3t+JQ9EMG8Q+f1KNJ0qziL X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-MS-Office365-Filtering-Correlation-Id: f9fbb973-2ff6-4a8c-49b2-08d333786b21 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:Si3RKe+V7I5hRVVQ4FCzwLg8Lck3Za1k+1JU2t+t6gOOOrzDZGX0+g9RjvKohgxbSOVvHfapF8BVGHysWxQU0uqjny1fJHeBW3IVYZp8KSDk6eAM78dxA36sNjSFc2Pqn0dalWRtFxcCC+cTY6/xm+H0QRc+vMJpsEEA8UgQcMQRLLYZJD3Heid1O+01cmP2Rv+/7YhhrlrjTnQ1OztIv4tyPjXzd9ITpnlEGVpDbcylkta9g4CTawB3RZ8gtXiZk4K/BdTAk1tIQmP8n3iWyIrJXXAaqrxhpkVM5W+rXZgt9wiKukG64L6XJR5sKfuQVIzr2+GWcXKAc80pQpCFSaVwmuzp80+hepo5cr9IND1aaJv0oStdDHXITYul6Q1Nt86AukC4IgY3Z08LcC0ylXrPCrTOIgRuLV1gO9nGtUlkguNCOFcB29QW+ElOBYpmNq8B/JxoR90xMohTVDrejyAYWsHKZt7qewCoZ4R0bisRVvSC/Pg26qHemGlAjvzg4IT3XaGBCargjonTeJ4aQBCh0DZzIxgjkzr8J9hCd16Ql19PYSv+bi++RSvkjuBmMaHBd5FGrzAJSK/09NU6RByZHy0zvZxfhfwWhXUxRAk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:BNI5NBL/iUT5OkMu9x3X9wNBwfOaabtStUdV9mwZ+lSejmEAriBGP8q/U6X3RVx2DYHpuP6Kukeb33meGGKnxDD9MMzpXQUdZwRassF2v+8itaHmT4TR513f9i6KxKc54ALmofN7W2QmI8smkPt+F2c098yivgS3bxlWC7jctlaWfTYKL+QdVrmTfkf5LbUmweqKDozMajdMAo8YTV1dNBAq+Cm1Hg3fXihdMFLk1Dty5xtSgMRGsaLOyyNqf7LlZxlQIc0jmwUSiFMFf55Fwn2k5RWnQ9Z0fH+OQ1Z3eRNBzfUIWmrFiQ6y9yzrOgtDoyCU42c/nDFTWZVqGDVmfdzefA2tEbr3eq7DAQ7exn3lhH+soya86XW63b0niAGI X-Forefront-PRVS: 0850800A29 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(52034003)(24454002)(377424004)(50466002)(40100003)(1076002)(47776003)(110136002)(76176999)(2950100001)(46406003)(50986999)(1096002)(5008740100001)(15975445007)(4326007)(54356999)(87976001)(5004730100002)(586003)(2906002)(66066001)(97756001)(23726003)(77096005)(42186005)(19580395003)(15395725005)(3846002)(5001960100002)(122386002)(6116002)(33656002)(86362001)(189998001)(61506002)(93886004)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:B43uZm5IVMF6rgAOHjyp+b6YUb+V3iX6Ylv2U7Z?= =?us-ascii?Q?nMORKnSieVOCqGu27eXXomYTzQLZQe1PnC5W1Np4lwXrQpTJ9e0QQKwgyVT9?= =?us-ascii?Q?a6r9g0na9MnMEaIOBvLhBFCRfGhaKc870itbcyv5fzVnvlFodAWhfd8mJVdh?= =?us-ascii?Q?vbdgqbkdO91ispL8TAACwZq8/R6UbjuCOdRBmbHXxdKH7AW6usRuquIMrW57?= =?us-ascii?Q?uHpJHdLZ3FB3V6H/iXFBbp1VF7bBS5PpoVXkVxtpw1D9tW8jjYAhAezak5zc?= =?us-ascii?Q?TxPmdPeUcp+JQi/ijRFGDRGJVbm8YWy3DHwEnpH3WyP/tzfwN+3SnABH+F2a?= =?us-ascii?Q?UZp2Ip/qnhelzr8cdXNXVl0RnkWwGRpLBBSqaCs1dBjzNcdtwCpxlpJJKgcY?= =?us-ascii?Q?FEci0kFwARildDZdYVD72I4GDbBTQ/PGKbs1LIYbEiDC0DhcjcSZA1qFYggd?= =?us-ascii?Q?GRrrgLpc+VF9AwL0qou8lGuc3rHW7NKFmVrLUcDpjpbhWvcEIxyoUjhUZMmg?= =?us-ascii?Q?xVjoMLu0+XbZlQ0ggoBrd5MGijeD04k1Mc6jMKffLOfY5anm6dvFc6ovmckN?= =?us-ascii?Q?pxOZlFA3ncFILauLt7n5lP4Xaq6/7OsQ5hQOMMo/bY/yz3NVzDH+CMR2qs8X?= =?us-ascii?Q?qNWfAYC6qWlJaPD5NVsAI7MOCN4p+MtCEx6YdzsVJ/nmjGz9gv0W1Zj1up/Y?= =?us-ascii?Q?ZV/GF84n2Yr2sn7LzFjhiMEDP6mQHc40bMsu0WyuviD8wkywdXFClNLmR3Sg?= =?us-ascii?Q?UT6YzHLFM4E9q6M65lk64QZEv3ONXTkD+JQfR3WSGxJTkkwodeJFCUhVJkae?= =?us-ascii?Q?YZgCNfYzygKi31KlIVfXxfcSxTycU5YR47V4tRBW6f5JRYaucWO1lhyh3LZc?= =?us-ascii?Q?AMX5lVBq++Ep/DOdvqwU1MuvqI6Xl6G9aGnpPTA2vw1ckdGgo3INkQ+1CQ7J?= =?us-ascii?Q?Alpp0DR2LUDE+5IaMSnYSm8/QUwEaoJZku/rCOwu2lmxU/Mk/gIEeZOx9V4N?= =?us-ascii?Q?DXxOw5fW1QH0muNpIfbZMGRtfM/0nk9UAVIhDTOoWrwFKwAb/PgE8LJIMNg4?= =?us-ascii?Q?4Zaf6OcQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 5:/odc2T3PU5ADwAJcC8HMi0UVruVF/E6BcKQTdN22U8rMJH39444rwhxeXXUWqtut0MmZLY9l/cBbfAq22f9R5Ex6vuCUXCtKssJmIE+S7vGd080lLrV6OuUcj5goXLRy6+ssd3lGQhgSlPF5CV9v2w==; 24:Uv/8QzH+StYuGdSQvCKOv6IRt9EsnETbPtoOjlvruVndnLWGdDrCjFaXOzdEnt+o31ukPak2PKszHs6r4G8c9WUsvhYQuwnUS2kk9ys0GoE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2016 06:47:44.9869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 06:47:51 -0000 On Thu, Feb 11, 2016 at 12:46:33PM +0100, Thomas Monjalon wrote: > 2016-01-29 09:40, Jerin Jacob: > > --- a/lib/librte_lpm/Makefile > > +++ b/lib/librte_lpm/Makefile > > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h > > +else > > SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h > > +endif > [...] > > --- a/lib/librte_lpm/rte_lpm.h > > +++ b/lib/librte_lpm/rte_lpm.h > > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) > > +#include "rte_lpm_neon.h" > > +#else > > #include "rte_lpm_sse.h" > > +#endif > > Instead of defaulting to x86 SSE, it would be better to replace > "else" by "elif X86/SSE". > I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx. Some architectures(tile)[1] are planning to emulate SSE instruction used in LPM for LPM library support.So that way it makes sense to use SSE as default. But if anyone has any objections then I can add the check else let keep in existing way. [1] http://dpdk.org/ml/archives/dev/2016-January/031147.html Jerin > By the way, what is the minimum SSE version required? >