From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B9D7695D5 for ; Fri, 12 Feb 2016 18:23:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 12 Feb 2016 09:23:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,436,1449561600"; d="scan'208";a="651324426" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 12 Feb 2016 09:23:19 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u1CHNI9X024299; Fri, 12 Feb 2016 17:23:18 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id u1CHNIsB003074; Fri, 12 Feb 2016 17:23:18 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id u1CHNIvW003067; Fri, 12 Feb 2016 17:23:18 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Fri, 12 Feb 2016 17:23:18 +0000 From: Ferruh Yigit To: Thomas Monjalon Message-ID: <20160212172318.GA30481@sivlogin002.ir.intel.com> Mail-Followup-To: Thomas Monjalon , Panu Matilainen , dev@dpdk.org References: <1453991505-15205-1-git-send-email-bernard.iremonger@intel.com> <2635551.TO27lmebJ9@xps13> <20160212165932.GA26328@sivlogin002.ir.intel.com> <10873835.umk2ANPAO0@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10873835.umk2ANPAO0@xps13> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: add default linux configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 17:23:22 -0000 On Fri, Feb 12, 2016 at 06:13:49PM +0100, Thomas Monjalon wrote: > 2016-02-12 16:59, Ferruh Yigit: > > On Fri, Feb 12, 2016 at 04:04:07PM +0100, Thomas Monjalon wrote: > > > 2016-02-12 14:31, Panu Matilainen: > > > > On 01/28/2016 04:31 PM, Bernard Iremonger wrote: > > > > > add config/defconfig_x86_64-default-linuxapp-gcc file. > > > > > > > > There was a related discussion back in March, see > > > > http://dpdk.org/ml/archives/dev/2015-March/014626.html > > > > > > > > I intended to go with that and submit patch(es) but the amount of > > > > duplication and new files gets mind-numbing when you make them for all > > > > existing targets. In other words, this approach doesn't scale. > > > > > > > > Thomas, I remember seeing a plan to include a configure script in DPDK > > > > many times in past months. Do you have something specific in mind, ie > > > > actually use autoconf or just a custom hand-written script named > > > > "configure" that roughly resembles autoconf configure or...? > > > > > > A script named "configure" looks fine. > > > Bruce introduced the idea of calling "make config" in the script: > > > http://dpdk.org/ml/archives/dev/2015-October/026256.html > > > Maybe it is a good start to move forward. > > > I think we have to choose between a script and a kconfig approach giving > > > the menus GUIs as bonus. > > > > > Another thing kconfig can help is to resolve dependencies, harder to make this with a > > script. Currently we already have dependencies, although not complex, and resolved > > within makefile. > > Dependencies are not so well resolved currently. > We have internal and external dependencies. > The internal ones would be better resolved with kconfig or a script. > The external dependencies are often managed by autotools but I'm sure > we prefer have a clean script instead of this beast ;) > > > I believe correct place to solve them is a configuration tool so that makefiles or > > source files can be clean. > > I think a configuration tool/script must help to make a working config. > But do you really think we should remove the gatekeepers in Makefiles? > I think we should remove combination of config related "if" checks from makefiles, "ENABLE-$(CONFIG_X) += y" should be sufficient. And if CONFIG_X should be set or not is be problem of the config tool. Thanks, ferruh