From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2254F2C7A
 for <dev@dpdk.org>; Tue, 16 Feb 2016 11:34:39 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga101.fm.intel.com with ESMTP; 16 Feb 2016 02:34:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="48610361"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63])
 by fmsmga004.fm.intel.com with SMTP; 16 Feb 2016 02:34:37 -0800
Received: by  (sSMTP sendmail emulation); Tue, 16 Feb 2016 10:34:36 +0025
Date: Tue, 16 Feb 2016 10:34:36 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Message-ID: <20160216103436.GA21696@bricha3-MOBL3>
References: <1453426717-2522-1-git-send-email-stephen@networkplumber.org>
 <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] igb: set default thresholds correctly based
 on mac type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2016 10:34:40 -0000

On Mon, Feb 01, 2016 at 02:59:13AM +0000, Lu, Wenzhuo wrote:
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Friday, January 22, 2016 9:39 AM
> > To: Lu, Wenzhuo
> > Cc: dev@dpdk.org; Stephen Hemminger
> > Subject: [PATCH] igb: set default thresholds correctly based on mac type
> > 
> > This brings the DPDK igb driver inline with the behavior used by the current Linux
> > driver. The IGB hardware has several different MAC types and the threshold
> > values that work vary based on the hardware.
> > 
> > Since DPDK 1.8 it has been up to devices to provide the correct default
> > configuration parameter. But the igb driver gives values that are broken on
> > some devices, and always causes a warning message at startup.
> > 
> > Please test this on real hardware, I don't have the luxury of a hardware lab full
> > of variations of this chip.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
Applied to dpdk-next-net/rel_16_04

/Bruce