From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4672BC166 for ; Tue, 16 Feb 2016 16:28:21 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 16 Feb 2016 07:27:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="916067890" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by fmsmga002.fm.intel.com with SMTP; 16 Feb 2016 07:27:36 -0800 Received: by (sSMTP sendmail emulation); Tue, 16 Feb 2016 15:27:35 +0025 Date: Tue, 16 Feb 2016 15:27:35 +0000 From: Bruce Richardson To: "Chen Jing D(Mark)" Message-ID: <20160216152735.GA13784@bricha3-MOBL3> References: <1453974359-20895-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453974359-20895-1-git-send-email-jing.d.chen@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 15:28:21 -0000 On Thu, Jan 28, 2016 at 05:45:59PM +0800, Chen Jing D(Mark) wrote: > From: "Chen Jing D(Mark)" > > When legacy TX func tries to free a bunch of mbufs, it will free > them one by one. This change will scan the free list and merge the > requests in case they belongs to same pool, then free once, which > will reduce cycles on freeing mbufs. > > Signed-off-by: Chen Jing D(Mark) > --- > doc/guides/rel_notes/release_2_3.rst | 2 + > drivers/net/fm10k/fm10k_rxtx.c | 59 ++++++++++++++++++++++++++++----- > 2 files changed, 52 insertions(+), 9 deletions(-) > > diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst > index 99de186..20ce78d 100644 > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -3,7 +3,9 @@ DPDK Release 2.3 > > New Features > ------------ > +* **Optimize fm10k Tx func.** > > + * Free multiple mbufs at a time to reduce freeing mbuf cycles. > Is this really a significant enough change to warrant being called out in the release notes? Personally, I don't think so, so if you are ok with it, I'll just apply this patch without the RN update. /Bruce