From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16])
 by dpdk.org (Postfix) with ESMTP id 941A293C0
 for <dev@dpdk.org>; Tue, 16 Feb 2016 18:19:53 +0100 (CET)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3q4TZK25myzsb;
 Tue, 16 Feb 2016 18:19:53 +0100 (CET)
Date: Tue, 16 Feb 2016 18:21:20 +0100
From: Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160216182120.04dfe258@pcviktorin.fit.vutbr.cz>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: [dpdk-dev] vm_power_manager uses non-public API,
 broken build on top of installed SDK
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2016 17:19:53 -0000

Hello Thomas,

I have encountered an issue with the examples/vm_power_manager. It
includes the file lib/librte_power/channel_commands.h which is not a
public API. This breaks builds of examples based on just the installed
SDK (after calling install-sdk) as the channel_commands.h header is
missing there. I suppose that most of the time, the examples are being
build directly from the DPDK base directory and so nobody could see
this failing.

Steps:

DPDK_CONFIG=arm-armv7a-linuxapp-gcc
$(MAKE) -C $(@D) T=$(DPDK_CONFIG) RTE_KERNELDIR=$(LINUX_DIR) \          
         CROSS=$(TARGET_CROSS) config
$(MAKE) -C $(@D) T=$(DPDK_CONFIG) RTE_KERNELDIR=$(LINUX_DIR) \          
         CROSS=$(TARGET_CROSS) all
$(MAKE) -C $(@D) DESTDIR=$(@D)/examples-sdk \                           
         CROSS=$(TARGET_CROSS) install-sdk install-runtime              
$(MAKE) -C $(@D) RTE_KERNELDIR=$(LINUX_DIR) CROSS=$(TARGET_CROSS) \    
        RTE_SDK=$(@D)/examples-sdk/usr/local/share/dpdk \               
        T=$(DPDK_CONFIG) examples

(I also set CONFIG_RTE_BUILD_SHARED_LIB=y and
CONFIG_RTE_BUILD_COMBINE_LIBS=y but I don't see any relation here.)

I am not sure about the solution. Probably, it's possible to move the
contents of channel_commands.h into the rte_power.h.

And, there is no maintainer listed for the librte_power and related
stuff...

By the way, is there a command that installs the examples on the
target? I didn't find any yet...

Regards
Jan

-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic