From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1FC2BC366 for ; Thu, 18 Feb 2016 14:25:20 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 18 Feb 2016 05:25:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,465,1449561600"; d="scan'208";a="906003900" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by fmsmga001.fm.intel.com with ESMTP; 18 Feb 2016 05:25:19 -0800 Date: Thu, 18 Feb 2016 21:25:49 +0800 From: Yuanhan Liu To: Panu Matilainen Message-ID: <20160218132549.GN21426@yliu-dev.sh.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 13:25:21 -0000 On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: > Commit d0cf91303d73 added dependency on librte_net headers to vhost > but did not add this to the Makefile, which makes builds > non-deterministic. Curiously it is non-parallel build that is > consistently broken by this missing dependency, usually it's the other > way around, but trying to build without -j(n) fails with: Yeah, I have confirmed it; I was wondering why I didn't meet such build error. > > dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: > fatal error: rte_ip.h: No such file or directory > > Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") > Signed-off-by: Panu Matilainen Acked-by: Yuanhan Liu Thanks. BTW, please cc me for virtio/vhost patches next time, otherwise, it's easily got overlooked: too many emails. --yliu